Skip to content

Update dependency starlette to ^0.47.0 [SECURITY] #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency starlette to ^0.47.0 [SECURITY] #316

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 15, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Confidence
starlette (changelog) ^0.38.0 -> ^0.47.0 age confidence

GitHub Vulnerability Alerts

CVE-2024-47874

Summary

Starlette treats multipart/form-data parts without a filename as text form fields and buffers those in byte strings with no size limit. This allows an attacker to upload arbitrary large form fields and cause Starlette to both slow down significantly due to excessive memory allocations and copy operations, and also consume more and more memory until the server starts swapping and grinds to a halt, or the OS terminates the server process with an OOM error. Uploading multiple such requests in parallel may be enough to render a service practically unusable, even if reasonable request size limits are enforced by a reverse proxy in front of Starlette.

PoC

from starlette.applications import Starlette
from starlette.routing import Route

async def poc(request):
    async with request.form():
        pass

app = Starlette(routes=[
    Route('/', poc, methods=["POST"]),
])
curl http://localhost:8000 -F 'big=</dev/urandom'

Impact

This Denial of service (DoS) vulnerability affects all applications built with Starlette (or FastAPI) accepting form requests.

CVE-2025-54121

Summary

When parsing a multi-part form with large files (greater than the default max spool size) starlette will block the main thread to roll the file over to disk. This blocks the event thread which means we can't accept new connections.

Details

Please see this discussion for details: https://github.com/encode/starlette/discussions/2927#discussioncomment-13721403. In summary the following UploadFile code (copied from here) has a minor bug. Instead of just checking for self._in_memory we should also check if the additional bytes will cause a rollover.

    @&#8203;property
    def _in_memory(self) -> bool:
        # check for SpooledTemporaryFile._rolled
        rolled_to_disk = getattr(self.file, "_rolled", True)
        return not rolled_to_disk

    async def write(self, data: bytes) -> None:
        if self.size is not None:
            self.size += len(data)

        if self._in_memory:
            self.file.write(data)
        else:
            await run_in_threadpool(self.file.write, data)

I have already created a PR which fixes the problem: https://github.com/encode/starlette/pull/2962

PoC

See the discussion here for steps on how to reproduce.

Impact

To be honest, very low and not many users will be impacted. Parsing large forms is already CPU intensive so the additional IO block doesn't slow down starlette that much on systems with modern HDDs/SSDs. If someone is running on tape they might see a greater impact.

Release Notes

encode/starlette (starlette)

v0.47.2

Compare Source

Fixed

  • Make UploadFile check for future rollover #​2962.

New Contributors

Full Changelog: encode/starlette@0.47.1...0.47.2

v0.47.1: Version 0.47.1

Compare Source

Fixed

  • Use Self in TestClient.__enter__ #​2951
  • Allow async exception handlers to type-check #​2949

Full Changelog: encode/starlette@0.47.0...0.47.1

v0.47.0: Version 0.47.0

Compare Source

Added

  • Add support for ASGI pathsend extension #​2671.
  • Add partitioned attribute to Response.set_cookie #​2501.

Changed

  • Change methods parameter type from list[str] to Collection[str] #​2903.
  • Replace import typing by from typing import ... in the whole codebase #​2867.

Fixed

  • Mark ExceptionMiddleware.http_exception as async to prevent thread creation #​2922.

New Contributors

Full Changelog: encode/starlette@0.46.2...0.47.0

v0.46.2: Version 0.46.2

Compare Source

What's Changed

New Contributors

Full Changelog: encode/starlette@0.46.1...0.46.2

v0.46.1: Version 0.46.1

Compare Source

Fixed

  • Allow relative directory path when follow_symlinks=True #​2896.

Full Changelog: encode/starlette@0.46.0...0.46.1

v0.46.0: Version 0.46.0

Compare Source

Added

  • GZipMiddleware: Make sure Vary header is always added if a response can be compressed #​2865.

Fixed

  • Raise exception from background task on BaseHTTPMiddleware #​2812.
  • GZipMiddleware: Don't compress on server sent events #​2871.

Changed

  • MultiPartParser: Rename max_file_size to spool_max_size #​2780.

Deprecated

  • Add deprecated warning to TestClient(timeout=...) #​2840.

New Contributors

Full Changelog: encode/starlette@0.45.3...0.46.0

v0.45.3: Version 0.45.3

Compare Source

Fixed

Full Changelog: encode/starlette@0.45.2...0.45.3

v0.45.2: Version 0.45.2

Compare Source

Fixed
  • Make create_memory_object_stream compatible with old anyio versions once again, and bump anyio minimum version to 3.6.2 by @​graingert in #​2833.

Full Changelog: encode/starlette@0.45.1...0.45.2

v0.45.1: Version 0.45.1

Compare Source

Fixed
Refactor

Full Changelog: encode/starlette@0.45.0...0.45.1

v0.45.0: Version 0.45.0

Compare Source

Removed

Full Changelog: encode/starlette@0.44.0...0.45.0

v0.44.0: Version 0.44.0

Compare Source

Added
New Contributors

Full Changelog: encode/starlette@0.43.0...0.44.0

v0.43.0: Version 0.43.0

Compare Source

Removed

  • Remove deprecated allow_redirects argument from TestClient #​2808.

Added

  • Make UUID path parameter conversion more flexible #​2806.

New Contributors

Full Changelog: encode/starlette@0.42.0...0.43.0

v0.42.0: Version 0.42.0

Compare Source

Added
  • Raise ClientDisconnect on StreamingResponse #​2732.
Fixed
  • Use ETag from headers when parsing If-Range in FileResponse #​2761.
  • Follow directory symlinks in StaticFiles when follow_symlinks=True #​2711.
  • Bump minimum python-multipart version to 0.0.18 0ba8395.
  • Bump minimum httpx version to 0.27.0 #​2773.
New Contributors

Full Changelog: encode/starlette@0.41.3...0.42.0

v0.41.3: Version 0.41.3

Compare Source

Fixed
  • Exclude the query parameters from the scope[raw_path] on the TestClient #​2716.
  • Replace dict by Mapping on HTTPException.headers #​2749.
  • Correct middleware argument passing and improve factory pattern #​2752.

Full Changelog: encode/starlette@0.41.2...0.41.3

v0.41.2: Version 0.41.2

Compare Source

What's Changed

Full Changelog: encode/starlette@0.41.1...0.41.2

v0.41.1: Version 0.41.1

Compare Source

What's Changed

Full Changelog: encode/starlette@0.41.0...0.41.1

v0.41.0: Version 0.41.0

Compare Source

Added

v0.40.0: Version 0.40.0

Compare Source

This release fixes a Denial of service (DoS) via multipart/form-data requests.

You can view the full security advisory:
GHSA-f96h-pmfr-66vw

Fixed

  • Add max_part_size to MultiPartParser to limit the size of parts in multipart/form-data
    requests fd038f3.

v0.39.2: Version 0.39.2

Compare Source

Fixed
  • Allow use of request.url_for when only "app" scope is available #​2672.
  • Fix internal type hints to support python-multipart==0.0.12 #​2708.

Full Changelog: encode/starlette@0.39.1...0.39.2

v0.39.1: Version 0.39.1

Compare Source

Fixed

  • Avoid regex re-compilation in responses.py and schemas.py #​2700.
  • Improve performance of get_route_path by removing regular expression usage #​2701.
  • Consider FileResponse.chunk_size when handling multiple ranges #​2703.
  • Use token_hex for generating multipart boundary strings #​2702.

Full Changelog: encode/starlette@0.39.0...0.39.1

v0.39.0: Version 0.39.0

Compare Source

Added

  • Add support for HTTP Range to FileResponse #​2697

Full Changelog: encode/starlette@0.38.6...0.39.0

v0.38.6: Version 0.38.6

Compare Source

Fixed
  • Close unclosed MemoryObjectReceiveStream in TestClient #​2693.

Full Changelog: encode/starlette@0.38.5...0.38.6

v0.38.5: Version 0.38.5

Compare Source

Fixed
  • Schedule BackgroundTasks from within BaseHTTPMiddleware #​2688.
    This behavior was removed in 0.38.3, and is now restored.

Full Changelog: encode/starlette@0.38.4...0.38.5

v0.38.4: Version 0.38.4

Compare Source

Fixed
  • Ensure accurate root_path removal in get_route_path function #​2600

Full Changelog: encode/starlette@0.38.3...0.38.4

v0.38.3: Version 0.38.3

Compare Source

Added
Fixed
  • Don't poll for disconnects in BaseHTTPMiddleware via StreamingResponse #​2620.

Full Changelog: encode/starlette@0.38.2...0.38.3

v0.38.2: Version 0.38.2

Compare Source

Fixed
  • Fix routing.get_name() not to assume all routines have __name__ #​2648

Full Changelog: encode/starlette@0.38.1...0.38.2

v0.38.1: Version 0.38.1

Compare Source

Removed
  • Revert "Add support for ASGI pathsend extension" #​2649.

Full Changelog: encode/starlette@0.38.0...0.38.1

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from ks129 as a code owner October 15, 2024 19:18
@renovate renovate bot force-pushed the renovate/pypi-starlette-vulnerability branch 2 times, most recently from 1c29c1d to 9b996d5 Compare June 6, 2025 02:34
@renovate renovate bot force-pushed the renovate/pypi-starlette-vulnerability branch from 9b996d5 to 79f6a6a Compare July 21, 2025 23:31
@renovate renovate bot changed the title Update dependency starlette to ^0.40.0 [SECURITY] Update dependency starlette to ^0.47.0 [SECURITY] Jul 21, 2025
@renovate
Update dependency starlette to ^0.47.0 [SECURITY]
e9f6bbf 
| datasource | package   | from   | to     |
| ---------- | --------- | ------ | ------ |
| pypi       | starlette | 0.38.0 | 0.47.2 |
@renovate renovate bot force-pushed the renovate/pypi-starlette-vulnerability branch from 79f6a6a to e9f6bbf Compare July 22, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ks129 ks129 Awaiting requested review from ks129 ks129 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants