Skip to content

Adding typing hints#773

Draft
ThosRTanner wants to merge 4 commits intopython-zk:masterfrom
ThosRTanner:add-typing-hints
Draft

Adding typing hints#773
ThosRTanner wants to merge 4 commits intopython-zk:masterfrom
ThosRTanner:add-typing-hints

Conversation

@ThosRTanner
Copy link
Copy Markdown
Contributor

Fixes #

Why is this needed?

Proposed Changes

  • change 1
  • change 2
  • ...

Does this PR introduce any breaking change?

Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py
Comment thread kazoo/client.py
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py
Comment thread kazoo/client.py
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/recipe/lock.py Outdated
Comment thread kazoo/recipe/lock.py Outdated
Comment thread kazoo/recipe/lock.py
Comment thread kazoo/recipe/watchers.py Outdated
Comment thread kazoo/recipe/watchers.py Outdated
Comment thread kazoo/handlers/utils.py
Comment thread kazoo/handlers/utils.py Outdated
Comment thread kazoo/protocol/connection.py Outdated
Comment thread kazoo/protocol/connection.py
Comment thread kazoo/protocol/connection.py
Comment thread kazoo/client.py
Comment thread kazoo/client.py
@ThosRTanner ThosRTanner force-pushed the add-typing-hints branch 3 times, most recently from 339f1ec to 7edcb3b Compare April 22, 2026 17:08
Comment thread kazoo/recipe/partitioner.py Outdated
Comment thread kazoo/recipe/watchers.py
Comment thread kazoo/recipe/watchers.py Outdated
@ThosRTanner ThosRTanner force-pushed the add-typing-hints branch 2 times, most recently from 5da635b to d67849a Compare April 23, 2026 05:56
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 99.73580% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.29%. Comparing base (86e69f2) to head (84c0766).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
kazoo/handlers/utils.py 97.61% 1 Missing ⚠️
kazoo/recipe/lock.py 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   96.67%   96.29%   -0.39%     
==========================================
  Files          27       27              
  Lines        3553     3805     +252     
==========================================
+ Hits         3435     3664     +229     
- Misses        118      141      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ThosRTanner ThosRTanner force-pushed the add-typing-hints branch 4 times, most recently from a9318af to 5168260 Compare April 23, 2026 13:41
Comment thread kazoo/handlers/utils.py Outdated
@ThosRTanner ThosRTanner force-pushed the add-typing-hints branch 5 times, most recently from 7063c61 to f62a077 Compare April 28, 2026 20:03
Comment thread kazoo/client.py Outdated
Comment thread kazoo/client.py Outdated
Comment thread kazoo/interfaces.py Outdated
@ThosRTanner ThosRTanner force-pushed the add-typing-hints branch 2 times, most recently from 8111fd6 to 5035143 Compare April 28, 2026 20:06
@StephenSorriaux
Copy link
Copy Markdown
Member

Really appreciate the tons of work you put into this PR. Can't wait to see it ready!

@ThosRTanner
Copy link
Copy Markdown
Contributor Author

Really appreciate the tons of work you put into this PR. Can't wait to see it ready!
I shall probably put in a brand new PR - this one is a bit of a mess considering my problems with hound...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants