Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9295
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New FailuresAs of commit 1400092 with merge base aa35ca1 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justincdavis
force-pushed
the
feat/perspective_cvcuda
branch
from
745d7c7 to
1175844
Compare
zy1git
reviewed
Jan 5, 2026
Contributor
zy1git
left a comment
zy1git
left a comment
There was a problem hiding this comment.
I left comments for the first round review. Feel free to let me know your thoughts.
| # just check that the shapes/dtypes are the same, cvcuda warp_perspective uses different algorithm | ||
| # visually the results are the same on real images, | ||
| # realistically, the diff is not visible to the human eye | ||
| tolerance = 255 if interpolation is transforms.InterpolationMode.NEAREST else 125 |
Contributor
There was a problem hiding this comment.
The threshold number might need more investigations. @NicolasHug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented the Perspective kernel for CV-CUDA backend
Testing
python3 -m pytest test/test_transforms_v2.py::TestPerspective