specify rotation direction in RandomRotation docs#9351
Draft
ribbon-otter wants to merge 2 commits intopytorch:mainfrom
Draft
specify rotation direction in RandomRotation docs#9351ribbon-otter wants to merge 2 commits intopytorch:mainfrom
ribbon-otter wants to merge 2 commits intopytorch:mainfrom
Conversation
fixes issue#8828
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9351
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To alert the general public to the potentially counterintuitive behaviour positive numbers meaning rotation in the anticlockwise direction, this pull request explicitly states
[90, 90]rotates 90 degrees anticlockwise, and the reader can presumably deduce that this means that[0, 90]means a random rotation between 0 and 90 degrees anticlockwise.fixes issue#8828
I've marked this as a draft, so I can check to see that the documentation renders correctly, before fully submitting it.