Remove broken phototour dataset - #9580
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9580
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @hedsnz! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Resolves the following tickets:
The first issue quoted above has the latest information on this ticket, but in brief: The phototour dataset download URLs have been broken for several years. The domain is now owned by an unrelated party, and while currently the download returns a 404, this is a potential security issue pointing users to download uncontrolled files.
Given the recent update on the direction of development, i.e., dataset features are not going to be prioritised, the simplest solution here is to remove the phototour dataset entirely (instead of recreating and hosting the data). Even if you do not consider this a legitimate security risk, there's been quite a lot of time generated by this issue over the years, both in terms of people running into issues attempting to use the dataset, and in terms of security scanning software flagging this.
Thanks!