Skip to content

Feat:Add support for Pivot-Filter / Default Values#2271

Open
zhuyanhuazhuyanhua wants to merge 8 commits intoqax-os:masterfrom
zhuyanhuazhuyanhua:zhuhua
Open

Feat:Add support for Pivot-Filter / Default Values#2271
zhuyanhuazhuyanhua wants to merge 8 commits intoqax-os:masterfrom
zhuyanhuazhuyanhua:zhuhua

Conversation

@zhuyanhuazhuyanhua
Copy link
Contributor

@zhuyanhuazhuyanhua zhuyanhuazhuyanhua commented Mar 6, 2026

PR Details

Add support for Pivot-Filter / Default Values

Description

  1. add SelectedItems []string in SlicerOptions
  2. add buildSlicerItems
  3. fix addSlicerCache

Related Issue

#2154

Motivation and Context

How Has This Been Tested

Types of changes

  • [no] Docs change / refactoring / dependency upgrade
  • [no] Bug fix (non-breaking change which fixes an issue)
  • [yes] New feature (non-breaking change which adds functionality)
  • [no] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [yes] My code follows the code style of this project.
  • [no need] My change requires a change to the documentation.
  • [no need] I have updated the documentation accordingly.
  • [yes] I have read the CONTRIBUTING document.
  • [yes] I have added tests to cover my changes.
  • [yes] All new and existing tests passed.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2026
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.56%. Comparing base (37b6a8f) to head (c6937cf).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2271   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          32       32           
  Lines       26316    26348   +32     
=======================================
+ Hits        26201    26233   +32     
  Misses         60       60           
  Partials       55       55           
Flag Coverage Δ
unittests 99.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xuri xuri added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants