Repository navigation
Add new function GetShapes - #2408
Open
wangyica879112 wants to merge 3 commits into
Open
wangyica879112 wants to merge 3 commits into
wangyica879112 wants to merge 3 commits into
Conversation
- Add structure for decode shapes
wangyica879112
marked this pull request as ready for review
October 10, 2026 09:00
wangyica879112
changed the title
peng
self-requested a review
October 10, 2026 09:38
peng
requested changes
Oct 10, 2026
peng
left a comment
peng
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your pull request. I've left a comment.
| shape.NvSpPr.CNvPr.Name = opts.Format.Name | ||
| } | ||
| shape.SpPr.Ln = opts.Line.drawChartLn() | ||
| if shape.SpPr.Ln == nil && opts.Line.Width != defaultLineWidth { |
Collaborator
There was a problem hiding this comment.
The cyclomatic complexity of the addDrawingShape function is 16, we need keep cyclomatic complexity less than 16.
peng
added
the
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
This add get shapes support for the library.
Description
Related Issue
#436
Motivation and Context
This add get shapes support for the library.
How Has This Been Tested
Add unit tests and test by
go test .locally. All unit test cases passed.Types of changes
Checklist