Skip to content

Loading the thumbnail_full in preview#74

Open
ronitjadhav wants to merge 3 commits intomainfrom
70-show-better-image-in-the-preview
Open

Loading the thumbnail_full in preview#74
ronitjadhav wants to merge 3 commits intomainfrom
70-show-better-image-in-the-preview

Conversation

@ronitjadhav
Copy link
Collaborator

@ronitjadhav ronitjadhav commented Jul 27, 2023

Using the thumbnail_full to load the preview image.

Some thumbnail_full resources are not downloaded properly: eg: QGIS Dashboard
And the thumbnails are not properly aligned in the center

@ronitjadhav ronitjadhav linked an issue Jul 27, 2023 that may be closed by this pull request
@ronitjadhav ronitjadhav requested a review from ismailsunni July 27, 2023 08:27
@ronitjadhav
Copy link
Collaborator Author

@ismailsunni
I made updates to load thumbnail if thumbnail_full is not able to load, and aligning the thumbnail in center.
I noticed there are no thumbnails for Models.

Copy link
Collaborator

@ismailsunni ismailsunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, and it's working fine and the preview looks better.
Unfortunately, the performance is slightly down for some resources with big file-size thumbnails (slower to show the preview).

Some options:

  1. Add a loading icon when the full thumbnail is not fully downloaded
  2. Download the full thumbnail in the background
  3. Add an option in the setting to select which thumbnail to be shown (full or cropped)

1 and 2 are similar but more complicated and need #44. So, let's implement the 3rd one.

Note: I got a QGIS crash when I played with it, not sure with which resource though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Better Image in the Preview

2 participants