Add resolution information to digitizer#25958
Open
Ofenhed wants to merge 1 commit intoqmk:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where libinput refuses to accept the QMK digitizer because of missing information.
Description
I'm surprised to not find an issue in the QMK issue tracker, but the digitizer will currently fail with libinput with
libinput bug: missing tablet capabilities: resolution. Ignoring this device.. There is more information and a workaround in Evidlo/remarkable_mouse#18.This PR adds resolution information by adding physical size to the digitizer. The size doesn't really matter, as far as I can tell, but libinput won't play if it's missing.
Note that I'm not at all familiar with HID or USB protocols, but as far as I can tell from HID Usage Tables 1.12 (page 134), my changes seem to conform to the protocol. I have also verified that libinput is happy with the extra information in the descriptor.
Types of Changes
Issues Fixed or Closed by This PR
This issue had not been reported.
Checklist