Fix JSON type for SELECT_SOFT_SERIAL_SPEED#26003
Open
jakoschiko wants to merge 1 commit intoqmk:masterfrom
Open
Fix JSON type for SELECT_SOFT_SERIAL_SPEED#26003jakoschiko wants to merge 1 commit intoqmk:masterfrom
jakoschiko wants to merge 1 commit intoqmk:masterfrom
Conversation
jakoschiko
added a commit
to jakoschiko/Split65
that referenced
this pull request
Feb 11, 2026
If SELECT_SOFT_SERIAL_SPEED is defined, it triggers a QMK bug. A JSON with an invalid path is generated. The validation against keyboard.jsonschema fails. We can remove SELECT_SOFT_SERIAL_SPEED because it's set to the default value, anyway. See qmk/qmk_firmware#26003
d1f169e to
28d984a
Compare
zvecr
approved these changes
Feb 11, 2026
jakoschiko
added a commit
to jakoschiko/Split65
that referenced
this pull request
Feb 11, 2026
If SELECT_SOFT_SERIAL_SPEED is defined, it triggers a QMK bug. A JSON with an invalid type is generated. The validation against keyboard.jsonschema fails. We can remove SELECT_SOFT_SERIAL_SPEED because it's set to the default value, anyway. See qmk/qmk_firmware#26003
Author
|
The needed to adjust the commit message, it was outdated. |
28d984a to
28df99c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the variable
SELECT_SOFT_SERIAL_SPEED, the JSON definition ininfo_config.hjsondoesn't matchkeyboard.jsonschema.Description
If I define the variable
SELECT_SOFT_SERIAL_SPEEDin my keyboard firmware, the generated JSON is invalid. The validation againstkeyboard.jsonschemawill fail. I seems thatinfo_config.hjsondoesn't matchkeyboard.jsonschemafor this case.The compile error only happened after migrating my keyboard firmware from a very old version of qmk_firmware to the most recent one.
qmk_firmware/data/schemas/keyboard.jsonschema
Lines 914 to 929 in b01ed7d
Types of Changes
Issues Fixed or Closed by This PR
Checklist