Conversation
|
From local testing, it seems the current changes are sufficient to pass JET analysis. julia> JET.test_package(QuantumOptics; target_defined_modules=true)
Test Passed |
Krastanov
left a comment
There was a problem hiding this comment.
Neat! This was easier than expected, but great nonetheless. Could you let me know why you need the QuantumOpticsBase. prepended to coherentspinstate? If I am reading this correctly, coherentspinstate is already imported at the start of the file.
|
Also, could you rename the file to The failures are probably because the file was not explicitly included in |
Actually, these changes should be in the Aqua PR, most of them are related to the type piracy error with Aqua, I will move them there to keep this PR clean. |
Krastanov
left a comment
There was a problem hiding this comment.
whoops, you added the Manifest.toml to the commit (I guess we never bothered adding it to .gitignore). Could you please remove it?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 97.03% 97.35% +0.31%
==========================================
Files 18 18
Lines 1554 1700 +146
==========================================
+ Hits 1508 1655 +147
+ Misses 46 45 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Part of #442