Skip to content

Add JET tests#446

Merged
Krastanov merged 3 commits intoqojulia:masterfrom
ErikQQY:qqy/jet
May 28, 2025
Merged

Add JET tests#446
Krastanov merged 3 commits intoqojulia:masterfrom
ErikQQY:qqy/jet

Conversation

@ErikQQY
Copy link
Copy Markdown
Contributor

@ErikQQY ErikQQY commented May 28, 2025

Part of #442

@ErikQQY
Copy link
Copy Markdown
Contributor Author

ErikQQY commented May 28, 2025

From local testing, it seems the current changes are sufficient to pass JET analysis.

julia> JET.test_package(QuantumOptics; target_defined_modules=true)
Test Passed

Copy link
Copy Markdown
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! This was easier than expected, but great nonetheless. Could you let me know why you need the QuantumOpticsBase. prepended to coherentspinstate? If I am reading this correctly, coherentspinstate is already imported at the start of the file.

@Krastanov
Copy link
Copy Markdown
Member

Also, could you rename the file to test_jet.jl, same as discussed in the other PR?

The failures are probably because the file was not explicitly included in runtests.jl

@ErikQQY
Copy link
Copy Markdown
Contributor Author

ErikQQY commented May 28, 2025

Could you let me know why you need the QuantumOpticsBase. prepended to coherentspinstate? If I am reading this correctly, coherentspinstate is already imported at the start of the file.

Actually, these changes should be in the Aqua PR, most of them are related to the type piracy error with Aqua, I will move them there to keep this PR clean.

Copy link
Copy Markdown
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, you added the Manifest.toml to the commit (I guess we never bothered adding it to .gitignore). Could you please remove it?

@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (d2c71fe) to head (49df2ea).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   97.03%   97.35%   +0.31%     
==========================================
  Files          18       18              
  Lines        1554     1700     +146     
==========================================
+ Hits         1508     1655     +147     
+ Misses         46       45       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov Krastanov merged commit dac3cc7 into qojulia:master May 28, 2025
8 checks passed
@ErikQQY ErikQQY deleted the qqy/jet branch May 28, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants