support multiple aws accounts with credentials - #140
Conversation
Signed-off-by: Bryan Fang <bryan.fang@aktana.com>
39862e0 to
2b01ff7
Compare
vmercierfr
left a comment
vmercierfr
left a comment
There was a problem hiding this comment.
Thanks for your work to add the support of multi AWS accounts!
Some logics are duplicated (could be simplified to faciliate maintenance), and we may improve exporter scrape duration with GO routines.
The main blocker could be to continue to support multiple AWS authentication methods (including AWS assumed role), I would like to propose an another alternative in upcoming weeks.
| func (c *rdsCollector) fetchMetrics() error { | ||
| c.logger.Debug("received query") | ||
|
|
||
| if len(c.accountRegionClients) > 0 { |
There was a problem hiding this comment.
The business logic is duplicated, while we may build a single loop with all AWS accounts to proceed.
In this implementation, AWS accounts will be retrieved one by one, whereas we could rely on Goroutine to collect them in parallel execution.
|
It seems very interesting to me since I use the cloudwatch exporter with multiple roles to access multi-AWS accounts. I will be following this change At YACE we have something very interesting: |
3 participants
No description provided.