Conversation
When changing a team, we had duplicated metrics: one with the old team name, and one with the new team name. This is because the `Load()` method in only setting / updating metrics, but its not clearing the old ones. This patch is adding a `Reset()` at the beginning to ensure clearing of stale data. Signed-off-by: Maxime Demolin <maxime_dev@demol.in>
MaximeD
force-pushed
the
mdemolin/reset
branch
from
e442e8f to
b7f03d9
Compare
Member
Author
|
#ee |
dlapina
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When changing a team, we had duplicated metrics: one with the old team name, and one with the new team name.
This is because the
Load()method in only setting / updating metrics, but its not clearing the old ones. This patch is adding aReset()at the beginning to ensure clearing of stale data.