feature/delete gradio #142
Conversation
Summary by CodeRabbitRelease Notes
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThis PR removes the entire Gradio-based Web UI implementation (including app, components, configuration, and models) and the complete TypeScript SDK (HTTP client, WebSocket client, types, scripts), along with corresponding documentation updates and the Gradio dependency. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings, 1 inconclusive)
✨ Finishing touches
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (30)
💤 Files with no reviewable changes (28)
🧰 Additional context used📓 Path-based instructions (1)**/*.py📄 CodeRabbit inference engine (AGENTS.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
rogue/__main__.py (1)
252-252: Update stale comment to reflect supported modes.The comment mentions "ui" mode, but UI mode support has been removed in this PR. Update the comment to only list the currently supported modes: server, cli, and tui.
🔎 Proposed fix
- # Handle regular modes (ui, cli, server, tui) + # Handle regular modes (server, cli, tui)
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
packages/sdk/package-lock.jsonis excluded by!**/package-lock.jsonuv.lockis excluded by!**/*.lock
📒 Files selected for processing (30)
AGENTS.mdCONTRIBUTING.mdREADME.mdpackages/sdk/README.mdpackages/sdk/package.jsonpackages/sdk/src/client.tspackages/sdk/src/index.tspackages/sdk/src/scripts/eval-runner.tspackages/sdk/src/sdk.tspackages/sdk/src/types.tspackages/sdk/src/websocket.tspackages/sdk/tsconfig.jsonpyproject.tomlrogue/__init__.pyrogue/__main__.pyrogue/run_ui.pyrogue/ui/__init__.pyrogue/ui/app.pyrogue/ui/components/__init__.pyrogue/ui/components/config_screen.pyrogue/ui/components/interviewer.pyrogue/ui/components/report_generator.pyrogue/ui/components/scenario_generator.pyrogue/ui/components/scenario_runner.pyrogue/ui/config/__init__.pyrogue/ui/config/settings.pyrogue/ui/config/theme.pyrogue/ui/models/__init__.pyrogue/ui/models/interview.pyrogue/ui/models/results.py
💤 Files with no reviewable changes (28)
- rogue/ui/config/init.py
- packages/sdk/package.json
- packages/sdk/README.md
- rogue/ui/components/scenario_generator.py
- packages/sdk/tsconfig.json
- README.md
- rogue/init.py
- packages/sdk/src/index.ts
- rogue/ui/models/interview.py
- packages/sdk/src/client.ts
- rogue/ui/models/results.py
- rogue/ui/app.py
- rogue/ui/components/config_screen.py
- CONTRIBUTING.md
- packages/sdk/src/websocket.ts
- rogue/ui/init.py
- pyproject.toml
- rogue/ui/components/scenario_runner.py
- packages/sdk/src/types.ts
- rogue/ui/components/init.py
- rogue/ui/config/theme.py
- rogue/ui/components/interviewer.py
- AGENTS.md
- packages/sdk/src/sdk.ts
- rogue/ui/models/init.py
- rogue/ui/components/report_generator.py
- rogue/run_ui.py
- packages/sdk/src/scripts/eval-runner.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py
📄 CodeRabbit inference engine (AGENTS.md)
**/*.py: Format Python code with Black
Ensure code passes flake8 linting
Run mypy with the repository configuration for static typing
Run Bandit security checks using .bandit.yaml configuration
Use isort import conventions for import ordering
Add type hints to all function signatures
Follow PEP 8 naming (snake_case for variables/functions, PascalCase for classes)
Use try/except around code that may raise exceptions
Files:
rogue/__main__.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: codestyle
- GitHub Check: rogue_sanity
🔇 Additional comments (1)
rogue/__main__.py (1)
1-274: Clean removal of UI mode support.The UI mode has been cleanly removed from the entrypoint:
- UI-related imports removed
- UI subparser removed from argument parsing
- UI mode handling removed from main logic
- All remaining modes (server, cli, tui) continue to function correctly
The change aligns with the PR objective to remove Gradio-based UI components.
Description
Motivation and Context
Type of Change
Changes Made
Screenshots/Examples (if applicable)
Checklist
uv run black .to format my codeuv run flake8 .and fixed all issuesuv run mypy --config-file .mypy.ini .and addressed type checking issuesuv run bandit -c .bandit.yaml -r .for security checksuv run pytestand all tests passTesting
Test Configuration:
Test Steps:
1.
2.
3.
Additional Notes
Related Issues/PRs