Merged
Conversation
- Add Jest/React Testing Library setup - Add tests for: - Redux auth slice (login, logout, state transitions) - Redux store configuration - Firebase authentication (sign in, sign up, sign out) - Firestore operations (doc, setDoc, getDoc) - Firebase configuration validation - Button component - Input component - Add Firebase mocks for testing - Add GitHub Actions workflow to run tests on PRs - Workflow blocks merge if tests don't pass 90% threshold - Add test:ci script for CI environments Total: 83 tests across 7 test suites
…culation - Changed npm ci to npm install to avoid package-lock sync issues - Fixed bash regex parsing (removed -P flag not available on Ubuntu) - Simplified workflow to single test job with quality gate check - Use awk instead of bc for arithmetic operations - Fixed quality gate job to properly check needs.test.result
- Import Button and Input directly from their folders instead of barrel export - Barrel export (components/index.js) triggers Firebase init via Layout/Navbar - All 83 tests now pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Total: 83 tests across 7 test suites
PR Type
Tests, Enhancement
Description
Add comprehensive Jest/React Testing Library test suite with 83 tests
Create Firebase mocks for authentication and Firestore operations
Implement GitHub Actions CI/CD workflow with 90% pass rate quality gate
Add test configuration and environment setup for CI environments
Diagram Walkthrough
File Walkthrough
8 files
Firebase authentication and Firestore operation mocksButton component unit tests with variantsInput component unit tests with typesFirebase authentication functions test suiteFirebase configuration and environment validationFirestore document operations test suiteRedux auth slice reducer and selectors testsRedux store configuration and integration tests3 files
Jest test environment setup and global mocksTest environment variables for Firebase configGitHub Actions CI/CD workflow with quality gates1 files
Add test dependencies and test:ci script