Add missing documentation and enhance test coverage for getting-started-reactive-crud#1298
Add missing documentation and enhance test coverage for getting-started-reactive-crud#1298jedla97 wants to merge 1 commit intoquarkusio:developmentfrom
Conversation
| @@ -0,0 +1,117 @@ | |||
| # Getting started with Quarkus | |||
|
|
|||
| This is a CRUD service exposing endpoints over REST. These endpoints are used for get, add, update | |||
There was a problem hiding this comment.
Don't we have a guide for that?
Because we usually avoid duplicating content in the quickstarts. Some of them have a README with a link to the guide.
There was a problem hiding this comment.
I wasn't able to find it so I write at least what it's does. Now after some digging I found out that the guide was there in past but was changed by this PR . It seems that PR replace this quickstart by hibernate-reactive-panache-quickstart.
|
Any update on this issue? |
|
@jedla97 Ping? |
…ed-reactive-crud.
91134e1 to
9ac73f7
Compare
|
@cescoffier Sorry I miss previous comment. I rebase this. As I wrote earlier the quarkusio/quarkus#17675 remove this quickstart from the guide. So it's on you and rest of the Quarkus team if they want the readme included or not. |
Status for workflow
|
Hi, this PR add documentation and additional tests to getting-started-reactive-crud.
As for the documentation whole readme was missing and I wasn't able to find any guide on quarkus.io/ so I wrote some steps for this as I was looking how it's work.
The test only included 2 things (get all and delete). I added coverage for testing add and update fruit as it can be useful for people who are looking how to send these request.
Check list:
Your pull request:
developmentbranch999-SNAPSHOTversion of Quarkusmvn clean test)mvn clean package -Pnative)mvn clean verify -Pnative)README.mdfile (with build and run instructions)pom.xmlandREADME.md