feat: Added ability to add quick filters #160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross-paypay
force-pushed
the
quick-filters
branch
from
47a4bfa to
20a1579
Compare
ross-paypay
force-pushed
the
quick-filters
branch
from
20a1579 to
f604a0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, my company had adopted Quickwit+Grafana, coming from Opensearch+OpenSearch Dashboard.
One feature we really miss from the OpenSearch dashboard is the ability to add quick filters that can be enabled/disabled.
The ability to temporary disable a filter without needing to remove and retype it from scratch is a nice QoL feature.
This PR adds the ability to add "quick filters" that are seperate from the main query.
These quick filters can easily be enabled/disabled.
It is heavily inspired by the OpenSearch implementation but adapted to Quickwit
Basic example
Available compare options
The add/remove magnifying glass icon behavior now adds quick filters instead of modifying the primary query.
The implementation heavily priorities on ergonomics and tries to reuse some of the patterns used by the metrics/bucket aggregations.
Feedback welcomed :D