Add cors debug mode #5955
Merged
Add cors debug mode #5955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
approved these changes
Oct 28, 2025
quickwit/quickwit-serve/src/rest.rs
Outdated
| } | ||
|
|
||
| fn build_cors(cors_origins: &[String]) -> CorsLayer { | ||
| let debug_mode = quickwit_common::get_bool_from_env("QW_ENABLE_DEBUG_CORS", false); |
There was a problem hiding this comment.
Suggested change
| let debug_mode = quickwit_common::get_bool_from_env("QW_ENABLE_DEBUG_CORS", false); | |
| let debug_mode = quickwit_common::get_bool_from_env("QW_ENABLE_CORS_DEBUG", false); |
quickwit/quickwit-serve/src/rest.rs
Outdated
| fn build_cors(cors_origins: &[String]) -> CorsLayer { | ||
| let debug_mode = quickwit_common::get_bool_from_env("QW_ENABLE_DEBUG_CORS", false); | ||
| if debug_mode { | ||
| info!("DEBUG CORS is enabled, localhost and 127.0.0.1 origins will be allowed"); |
There was a problem hiding this comment.
Suggested change
| info!("DEBUG CORS is enabled, localhost and 127.0.0.1 origins will be allowed"); | |
| info!("CORS debug mode is enabled, localhost and 127.0.0.1 origins will be allowed"); |
quickwit/quickwit-serve/src/rest.rs
Outdated
| if debug_mode { | ||
| info!("DEBUG CORS is enabled, localhost and 127.0.0.1 origins will be allowed"); | ||
| return CorsLayer::new() | ||
| .allow_methods([Method::GET]) |
There was a problem hiding this comment.
I have a feeling you will need more methods eventually: wanna add POST, PUT, PATCH, DELETE?
quickwit/quickwit-serve/src/rest.rs
Outdated
| return CorsLayer::new() | ||
| .allow_methods([Method::GET]) | ||
| .allow_origin(AllowOrigin::predicate(|origin, _parts| { | ||
| origin.as_bytes().starts_with(b"https://localhost:") |
There was a problem hiding this comment.
nit: easier to extend in the future
Suggested change
| origin.as_bytes().starts_with(b"https://localhost:") | |
| [b"https://localhost:", b"https://127.0.0.1:"] | |
| .iter() | |
| .any(|prefix| origin.as_bytes().starts_with(*prefix)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
QW_ENABLE_CORS_DEBUG=true, the originslocalhost:*and127.0.0.1:*will be allowedHow was this PR tested?
make test-all