Skip to content

Conversation

jberthier-ma
Copy link

No description provided.

@cjrh
Copy link
Collaborator

cjrh commented Oct 31, 2023

Hi @jberthier-ma, thanks for the contribution 😄

Would you be able to add tests?

The other thing I was wondering was the difference in output for the query __repr__. Could you give an example of the before and after? I am thinking through whether this is a semver break, since it modifies an existing user-facing output, so I want to know whether the change in __repr__ output is worth it.

Sidhant29 pushed a commit to Sidhant29/tantivy-py that referenced this pull request Mar 12, 2024
…-oss#150)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cjrh cjrh self-assigned this Sep 6, 2025
@cjrh
Copy link
Collaborator

cjrh commented Sep 6, 2025

I looked at the PR. There doesn't seem to be any geocoding stuff, just a new struct with a float. Closing.

@cjrh cjrh closed this Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants