Skip to content

Expose tantivy's TermQuery #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2023
Merged

Expose tantivy's TermQuery #175

merged 3 commits into from
Dec 20, 2023

Conversation

mocobeta
Copy link
Contributor

@mocobeta mocobeta commented Dec 17, 2023 •
edited
Loading

This may relate to #20.

This exposes Tantivy's TermQuery to tantivy-py.
I also noticed #53, but it seems incomplete and stale for a while.

  • Add Query.new_term_query() method with proper type hints.
  • Add a test method for TermQuery.

@mocobeta mocobeta mentioned this pull request Dec 17, 2023
Open
adamreichold
adamreichold reviewed Dec 17, 2023
View reviewed changes
adamreichold
adamreichold reviewed Dec 17, 2023
View reviewed changes
adamreichold
adamreichold reviewed Dec 17, 2023
View reviewed changes
@mocobeta
Copy link
Contributor Author

Hi,
This has received one approval (thank you @adamreichold for reviewing!)
I don't have permission to merge this into the main branch, could anyone take care of it?

@wallies wallies merged commit f94e046 into quickwit-oss:master Dec 20, 2023
@mocobeta mocobeta deleted the feat/expose-term-query branch December 20, 2023 09:48
@mocobeta
Copy link
Contributor Author

Thanks @wallies !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mocobeta @adamreichold @wallies