Postings writer codex + inverted index reader as trait#2819
Open
Postings writer codex + inverted index reader as trait#2819
Conversation
PSeitz-dd
changed the title
PSeitz-dd
force-pushed
the
postings-writer-enum-codec5
branch
5 times, most recently
from
aa480a7 to
e50407a
Compare
PSeitz-dd
force-pushed
the
postings-writer-enum-codec5
branch
from
e50407a to
6b59e2b
Compare
Convert SegmentReader, InvertedIndexReader and postinglists to traits. Add special functions to pushdown certain performance methods to keep them strictly typed. We rely on a ObjectSafeCodec contraption to avoid the proliferation of generics. That object's point is to make sure we can build TermScorer with a concrete codec specific type before reboxing it. (same thing for PhraseScorer). fix performance regression: fix incorrect scorer cast for buffered union bock wand
PSeitz-dd
force-pushed
the
postings-writer-enum-codec5
branch
from
6b59e2b to
6038455
Compare
this will remove the DocumentDeserialize (maybe added later in a different form)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked
benches/merge_segments.rs)