Feature/new arrivals refactor - #28
Open
Sewaraa wants to merge 2 commits into
Open
Conversation
Author
|
#before |
Author
|
#before |
Author
|
#after |
Author
|
#after |
Author
|
#after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I refactored the NewArrivals component to improve layout, usability, and responsiveness. Here's what I did:
1.Converted the component to a functional one.
2.Added filter tabs (All / Men / Women).
3.Added basic pagination to limit products per page.
4.Replaced Bootstrap with CSS Grid for better layout.
5.Displayed a message when no products are found.
6.Added skeleton loader while loading products.
7.Replaced icons with React Icons.
8.Made the layout responsive for all screen sizes.
9.Added aria-label to buttons for accessibility.