Conversation
|
💡 If you need a new version, create a new release after merge. |
There was a problem hiding this comment.
Pull request overview
Removes the Ubuntu 20.04 runner variant and simplifies the CI/release workflows to build/test/release a single runner image.
Changes:
- Removed the Ubuntu 20.04 Dockerfile and related “ubuntu20” build flavor.
- Simplified reusable workflows by collapsing
runner-image-uri-latest/runner-image-uri-ubuntu20into a singlerunner-image-uriinput. - Updated E2E workflow to create and validate only one runner scale set (plus a dummy one for job pickup).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Marks Ubuntu 20.04 runner support as deprecated/removed in the feature list. |
| Dockerfile.ubuntu20 | Deletes the Ubuntu 20.04 runner image definition. |
| .github/workflows/reusable--release.yaml | Removes dual-image version parity check; uses a single runner image input. |
| .github/workflows/reusable--e2e-test.yaml | Removes ubuntu20 runner provisioning/testing; switches to a single runner image input. |
| .github/workflows/reusable--e2e-test-jobs.yaml | Removes ubuntu20-specific conditional skips for Ruby steps. |
| .github/workflows/build.yaml | Removes the ubuntu20 build job and rewires e2e-test/release to depend on the single build job. |
Comments suppressed due to low confidence (1)
Dockerfile.ubuntu20:1
- The
RUNstep that downloadsdocker-${DOCKER_VERSION}.tgzviacurlfromhttps://download.docker.com/...and immediately extracts/installs it introduces a supply‑chain risk, because the binary is trusted and executed without any checksum or signature verification.
If an attacker were ever able to compromisedownload.docker.comor the TLS channel, they could deliver a malicious Docker binary that would be installed and later run with high privileges in your runner environment.
To harden this, fetch and verify the official checksum or signature for the Docker archive (or use a base image that already contains Docker from a trusted registry) before installation so the build fails on tampering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the outdated Ubuntu 20.04 runner.