Conversation
|
💡 If you need a new version, create a new release after merge. |
There was a problem hiding this comment.
Pull request overview
Adds a dedicated “wait-for-workflows” GitHub Actions workflow intended to provide a stable status check for auto-merge, and scopes the existing build workflow triggers using paths filters.
Changes:
- Added
.github/workflows/wait-for-workflows.yamlworkflow that runsint128/wait-for-workflows-action. - Added
pathsfilters to.github/workflows/build.yamlfor bothpull_requestandpushtriggers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/wait-for-workflows.yaml | Introduces a new workflow to wait on other workflows and surface a status check. |
| .github/workflows/build.yaml | Limits when the build workflow runs by adding path-based trigger filters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| jobs: | ||
| wait-for-workflows: | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
runs-on: ubuntu-slim is not a valid GitHub-hosted runner label (common labels are ubuntu-latest, ubuntu-24.04, ubuntu-22.04). This job will fail to start unless you have a self-hosted runner with the ubuntu-slim label; switch to a supported runner label or your self-hosted label.
| runs-on: ubuntu-slim | |
| runs-on: ubuntu-latest |
|
|
||
| jobs: | ||
| wait-for-workflows: | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
This workflow/job doesn’t declare permissions:. The rest of the repo’s workflows explicitly set minimal permissions (e.g. .github/workflows/build.yaml:28-31), and wait-for-workflows-action typically needs API write access (e.g. to create/update check runs). Add explicit permissions at the workflow or job level per the action’s requirements so it won’t fail under restricted default token permissions.
| runs-on: ubuntu-slim | |
| runs-on: ubuntu-slim | |
| permissions: | |
| checks: write | |
| contents: read |
| - Dockerfile | ||
| - entrypoint.sh | ||
| - e2e-tests/** | ||
| - hack/** |
There was a problem hiding this comment.
The path filter includes e2e-tests/**, but this repository directory is e2e-test/ (singular). As written, PRs that change e2e-test/** won’t trigger this workflow.
| - Dockerfile | ||
| - entrypoint.sh | ||
| - e2e-tests/** | ||
| - hack/** |
There was a problem hiding this comment.
Same issue on the push trigger: e2e-tests/** does not exist (repo uses e2e-test/). This will prevent builds on pushes that modify e2e tests.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jobs: | ||
| wait-for-workflows: | ||
| runs-on: ubuntu-slim | ||
| timeout-minutes: 15 | ||
| steps: | ||
| - uses: int128/wait-for-workflows-action@6f56a701a797895c1196d4e36554124637c639dd # v1.55.0 |
There was a problem hiding this comment.
This new workflow doesn’t declare any explicit permissions. In this repo, other workflows/jobs set minimal permissions explicitly (e.g., .github/workflows/build.yaml:28-31, .github/workflows/reusable--build.yaml:22-24). Add an explicit permissions block here (at least contents: read, and whatever else the wait action needs) so behavior doesn’t depend on repository default token permissions.
| push: | ||
| paths: | ||
| - .github/workflows/build.yaml | ||
| - .github/workflows/reusable--*.yaml | ||
| - Dockerfile | ||
| - entrypoint.sh | ||
| - e2e-test/** | ||
| - hack/** |
There was a problem hiding this comment.
Adding paths: filters under on: push: changes tag-triggered behavior: the workflow will only run for tag pushes if the tagged commit modifies one of these paths. If this workflow is expected to run for every tag (it currently has tags: ['*']), this can silently stop builds/releases for tags. Consider removing the paths filter for tag pushes (e.g., keep it only for pull_request, or split into separate workflows/events).
| pull_request: | ||
| paths: | ||
| - .github/workflows/build.yaml | ||
| - .github/workflows/reusable--*.yaml | ||
| - Dockerfile | ||
| - entrypoint.sh | ||
| - e2e-test/** | ||
| - hack/** |
There was a problem hiding this comment.
The PR description only mentions adding a wait-for-workflows status check, but this also adds paths: filters to the main build workflow (changing when CI runs for PRs and pushes). If this is intentional, please reflect it in the PR description; if not, consider reverting these trigger changes to avoid unexpected CI gaps.
This adds wait-for-workflows action to set up a status check for auto-merge.