Use Base.AbstractVecOrTuple instead of handwritten VectorOrTuple#683
Open
albertomercurio wants to merge 4 commits intoqutip:mainfrom
Open
Use Base.AbstractVecOrTuple instead of handwritten VectorOrTuple#683albertomercurio wants to merge 4 commits intoqutip:mainfrom
Base.AbstractVecOrTuple instead of handwritten VectorOrTuple#683albertomercurio wants to merge 4 commits intoqutip:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
=======================================
Coverage 21.50% 21.50%
=======================================
Files 57 57
Lines 3864 3864
=======================================
Hits 831 831
Misses 3033 3033 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ytdHuang
reviewed
Apr 6, 2026
CHANGELOG.md
Outdated
Comment on lines
+13
to
+19
| - Use `AbstractVecOrTuple` for type definitions. ([#679]) | ||
| - Allow specifying random number generator by keyword argument `rng` for the following random `Qobj` generating functions ([#680]): | ||
| - `rand_ket` | ||
| - `rand_dm` | ||
| - `rand_unitary` | ||
| - Fix benchmarks instability for autodiff. ([#681]) | ||
| - Use `Base.AbstractVecOrTuple` instead of handwritten `VectorOrTuple`. ([#683]) |
Member
There was a problem hiding this comment.
How about we just put them in one line:
- Use `AbstractVecOrTuple` for type definitions ([#679]). Note that it is changed to use `Base.AbstractVecOrTuple` instead ([#683]).
Because they are related.
Member
|
(just a link to PR #679, since this is an update to that one) |
albertomercurio
force-pushed
the
dev/patch-2
branch
from
38e0787 to
8536ec4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Thank you for contributing to
QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by running:make docs.CHANGELOG.mdshould be updated (regarding to the code changes) and built by running:make changelog.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
Describe the proposed change here.
Related issues or PRs
As title.