Conversation
Remove `_qz.websocket.connection != null` check which is always true
_qz.websocket.connection.established is only ever read in one place and can effectively be replaced by _qz.websocket.connection !== null
Extract WebSocket open attempt to dedicated function `connectToAddress`
Remove Safari check for onclose error handling. A close event before an open event can always be considered a connection failure. This is safe because we cleanup the event handler immediately after the open event.
- Move WebSocket constructor inside of the promise executor, so that all errors result in a rejected Promise, not an exception - Remove redundant `_qz.websocket.connection = null` in promise reject
akberenz
reviewed
Apr 16, 2026
Ref 39aaac4d24404be2debf0dcafcf8ccabda12d79e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow qz-tray.js to notify in a usable error when LocalNetworkAccess restrictions prevent a connection.
Detailed write-up here: https://qz.io/docs/lna
Closes #1382