56 need to process if the subdir is minidumps #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PipeItToDevNull
commented
Jan 29, 2025
PipeItToDevNull
commented
- Archives with Minidump subdirectory are accepted all else are rejected.
- We assume at least one file in that Minidump directory is valid and don't validate that
- Validation for all other archives was inverted, any single valid file will have the archive processed.
- The API won't process non .dmp files so it won't matter if they include trash
- MacOS puts stupid hidden files into archives so this takes care of that
…e will succeed since the API handles bad files just fine (doesn't try to process them)
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0d823220f-57.eastus2.4.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0d823220f-57.eastus2.4.azurestaticapps.net |
|
Docker images have been built and pushed:
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0d823220f-57.eastus2.4.azurestaticapps.net |
PipeItToDevNull
deleted the
56-need-to-process-if-the-subdir-is-minidumps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.