Fix vec_ptype2() fallback path when LHS is NULL#2128
Fix vec_ptype2() fallback path when LHS is NULL#2128DavisVaughan wants to merge 4 commits intomainfrom
vec_ptype2() fallback path when LHS is NULL#2128Conversation
|
There are unfortunately more revdep failures we are going to have to deal with from this Some related to POSIXlt going towards POSIXct more often. Some related to ptype2 being called more often, I think. |
f0074cc to
73581e7
Compare
|
We won't be able to do this right now due to the complexity of getting the sf methods compatible with this change, so we are going to have to wait on most of this until we can move all of the vctrs methods into sf itself first After that, it should hopefully be a bit easier to do this, since all of the vctrs methods will live in one place. Ideally, sf won't need to use the vctrs fallback mechanism at all, allowing us to simplify things as we've tried to do here (i.e. by removing I'll try and pluck out some of the unrelated changes (POSIXlt methods, any extra tests, etc) into their own PR to get those in. |
c601f52 to
aa0d5d1
Compare
Closes #2127
The goal of this PR was to fix this small
x_type->y_typetypo herevctrs/src/ptype2.c
Line 71 in 29c5518
But since that is run as the very first iteration of almost every
vec_ptype_common()call (because we start the reduction withx = NULL, y = xs[[1]]), it had a huge amount of fallout of weird buggy cases that relied on this.