Need to sort url parameters, in V4 Signature #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

barryhunter wants to merge 1 commit into racklin:master from barryhunter:patch-1

barryhunter commented Nov 9, 2020

Found this fork that adds V4 verification - which is great.

But run into problem, found the URL params needs to be sorted (eg when runing ListObjects on a bucket, it adds multiple when using delimiter+prefix for example)
https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html

Thought worth pushing this upstream.

This is the same change made in our copy geograph-project/geograph-project@466592a


          Need to sort url parameters, in V4 Signature

9a4fbf9

Found this fork that adds V4 verification - which is great. 

But run into problem, found the URL params needs to be sorted (eg when runing ListObjects on a bucket, it adds multiple when using delimiter+prefix for example)
https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html

Thought worth pushing this upstream. 

This is the same change made in our copy geograph-project/geograph-project@466592a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet