Added new theme that mimics maven surefire plugin#147
Open
msiemczyk wants to merge 1 commit intoradarsh:developfrom
Open
Added new theme that mimics maven surefire plugin#147msiemczyk wants to merge 1 commit intoradarsh:developfrom
msiemczyk wants to merge 1 commit intoradarsh:developfrom
Conversation
Since the plugin does not provide a way to define the test summary I've added new themes (maven and maven-parallel) and that inherit from standard theme but override summaryText to format it the way maven-surefire(and failsafe)-plugin used to do it maven. I've also updated unit tests so their passing again and added some new tests for new classes. Differences with maven plugin: - added the Time Elapsed to "Test Run: " line - changed "Results:" to "Summary:" as Gradle build outputs errors before Summary (maven includes errors in Results section).
Owner
|
Hi, this is great - thanks for contributing. Do you have a screenshot handy that shows what the generated output would look like? If not, no worries and I'll check it out later. |
Author
|
I do. I will provide them in couple minutes. |
Author
Author
|
@radarsh are you not okay with these changes being made? If not I will have to build custom version of the plugin and deploy to our own local repository so I just need to know if you going to apply these changes to your plugin or not. |
Owner
|
@msiemczyk just held up with a few things. I haven't had a chance to look at this PR in detail yet. |
Author
|
@radarsh did you have a chance to look at my PR? |
Owner
|
@msiemczyk I'm sorry but no. You'll hear from me when I have had a look. Appreciate your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Since the plugin does not provide a way to define the test summary I've
added new themes (maven and maven-plain) and that inherit from
standard and plain themes repsectively but override summaryText to format it the way
maven-surefire(and failsafe)-plugin used to do it maven. I've also
updated unit tests so their passing again and added some new tests for
new classes.
Differences with maven plugin:
Summary (maven includes errors in Results section).
Ideally the plugin provide a way to customize how the summary text looks like, but this will be harder to implement in a generic way that would satisfy everyone needs.