feat(presence): subtree-aware WAAPI exit detection (ADR 0011)#418
Merged
Conversation
Upgrade PresenceMachine to detect exit animations via the Web Animations API across the template root and its whole subtree, so an exit can be a @Keyframes OR a CSS transition, on the positioner OR the popup nested inside it — retiring the positioner "decoy keyframe" convention.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⚡ PerformanceTotal duration: 133.3 ms +2.2 ms (+1.7%) · Renders: 16 (+0) · Paint: 164.9 ms +5.9 ms (+3.7%) All benchmarks within noise (±20%). ✅ 4 tests within noise
Lower is better. ▲ regression · ▼ improvement · within-noise = |Δ| ≤ 20% of base median. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade PresenceMachine to detect exit animations via the Web Animations API across the template root and its whole subtree, so an exit can be a @Keyframes OR a CSS transition, on the positioner OR the popup nested inside it — retiring the positioner "decoy keyframe" convention.
Description