fix(exports): Add ./package.json to publishConfig exports#3819
Open
EricWardner wants to merge 1 commit intoradix-ui:mainfrom
Open
fix(exports): Add ./package.json to publishConfig exports#3819EricWardner wants to merge 1 commit intoradix-ui:mainfrom
EricWardner wants to merge 1 commit intoradix-ui:mainfrom
Conversation
The [Node.js docs](https://nodejs.org/api/packages.html) explicitly recommend exporting `./package.json` when using an exports map to avoid breaking changes. Fixes radix-ui#3818
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
"./package.json": "./package.json"to thepublishConfig.exportsmap inpackages/react/radix-ui/package.json.The existing
"./*"wildcard pattern interceptsrequire.resolve('radix-ui/package.json'), causing Node.js to look for./dist/package.json.mjsinstead of the actual file. This breaks tools like Storybook that resolvepackage.jsonto read package metadata.The Node.js docs explicitly recommend exporting
./package.jsonwhen using an exports map to avoid breaking changes.Fixes #3818