-
Notifications
You must be signed in to change notification settings - Fork 8
Migrate to the app router #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nygrenh
wants to merge
121
commits into
master
Choose a base branch
from
app-router
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te role translation keys to use 'as const' for improved type safety.
…s and enhance error handling. Added parameters for max completion tokens, debug payloads, and improved logging during retries. Updated invocation in process_file to enable debugging.
…e names should not be changed. Update process_file to disable debug payloads during Azure chat completion.
…ective to course instances page. Refactor permission page to use search parameters for sorting. Introduce DEFAULT_SERVICE_INFO_URL constant for playground settings.
# Conflicts: # services/course-material/src/components/ReferencesList.tsx
…es to include new route types and adjust documentation links.
…t redundant calls and improve state management. Update LanguageOptionsContext to allow undefined callback for language change. Adjust cleanup logic in course material page to use undefined instead of an empty function.
…ayout to eliminate its usage. Update QuickActionsMenu and UserMenu components to include new editPageRoute functionality and improve menu item handling. Add course-settings translation key and implement edit page link in QuickActionsMenu. Integrate Jotai Provider in ClientLayoutWrapper for state management.
…rvices by integrating react-i18next for translation. Update the corresponding locale files to include necessary translation keys.
… improving menu item management. Introduce hooks for language and quick actions menus, refactor user menu handling, and streamline menu item types for better consistency. Update package dependencies for @react-aria libraries.
…logo navigation. Adjust Layout component to utilize new prop, ensuring consistent navigation behavior across the application.
…layout consistency. Remove unnecessary elements from MainFrontendBreadCrumbs and update Topbar's Brand component to utilize an SVG logo. Adjust TabLinkNavigation margin for better spacing.
…login and signup paths, enhancing maintainability. Update aria-label attributes for improved accessibility and add corresponding translation keys in locale files.
…h functionality. Adjust gap between elements and add a vertical separator for improved visual separation. Replace placeholder search functions with actual backend imports for better search capabilities.
… to properties. Update useLanguageMenuItems, useQuickActionsItems, and useUserMenuItems to handle optional properties more gracefully, enhancing code robustness.
…on and test kustomization files to streamline deployment settings.
…oved reliability. Replace "Log in" text locator with role-based locator and update navigation menu ID for consistency across tests.
…ance validation tests for language codes.
…improved routing handling. Remove unused usePathname import and streamline component logic.
…useRouter for navigation. Update links to use route utility functions for consistency and improved readability across the application.
…and components - Introduced ChapterSelector class to encapsulate chapter link interactions. - Updated various test files to utilize ChapterSelector for clicking chapters. - Enhanced accessibility by adding data-testid attributes to chapter links in IllustrationCard and SimpleCard components. - Updated Topbar components to include data-testid attributes for language and user menus.
…r improved editor experience in workspace configuration.
…r experience by using useRouter for navigation. Replace window.location.replace with router.replace for improved routing handling.
…cture by removing unnecessary PageMarginOffset wrappers. This change enhances readability and maintains functionality across the application.
- Introduced a new ResetPassword component that validates reset token status using React Query. - Displays appropriate UI elements based on token validity, including error messages and loading indicators. - Integrated with existing components for a seamless user experience.
…u for improved clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cms
course-material
db-migrations
dependencies
Pull requests that update a dependency file
deployments
example-exercise
headless-lms
main-frontend
quizzes
root
scripts
seed
shared-module
system-tests
tmc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.