-
Notifications
You must be signed in to change notification settings - Fork 8
Don't use pnpm when starting the slim images #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using pnpm is unnecessary, and we don't want to accidentally start downloading new versions of pnpm or Node.js (which the project is otherwise configured to automatically do)
📝 WalkthroughWalkthroughConsolidates Node.js startup configuration from package.json scripts into Docker production images. Removes start scripts from six service package.json files and updates corresponding Dockerfiles to directly invoke node server.js with explicit NODE_ENV and PORT environment variables. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (12)
💤 Files with no reviewable changes (5)
🧰 Additional context used📓 Path-based instructions (1)**/*⚙️ CodeRabbit configuration file
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Using pnpm is unnecessary, and we don't want to accidentally start downloading new versions of pnpm or Node.js (which the project is otherwise configured to automatically do)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.