Skip to content

Support joins in update_all #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2025
Merged

Support joins in update_all #1293

merged 5 commits into from
Feb 10, 2025

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Feb 8, 2025 •
edited
Loading

Fix:

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/13201053254/job/36852899208

  1) Error:
UpdateAllTest#test_dynamic_update_all_with_one_joined_table:
NotImplementedError: NotImplementedError
    /usr/local/bundle/bundler/gems/rails-cd4708bbcd0d/activerecord/test/cases/relation/update_all_test.rb:95:in `test_dynamic_update_all_with_one_joined_table'

  2) Error:
UpdateAllTest#test_dynamic_update_all_with_two_joined_table:
NotImplementedError: NotImplementedError
    /usr/local/bundle/bundler/gems/rails-cd4708bbcd0d/activerecord/test/cases/relation/update_all_test.rb:113:in `test_dynamic_update_all_with_two_joined_table'

Ref rails/rails#53950

@aidanharan aidanharan marked this pull request as ready for review February 10, 2025 14:57
@aidanharan aidanharan merged commit f3c4d33 into main Feb 10, 2025
2 of 5 checks passed
@aidanharan aidanharan deleted the support-joins-in-update-all branch February 10, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan