⚡ Bolt: Replace JSON.parse(JSON.stringify) with structuredClone#299
⚡ Bolt: Replace JSON.parse(JSON.stringify) with structuredClone#299ralksta wants to merge 1 commit into
Conversation
Replaced `JSON.parse(JSON.stringify())` with native `structuredClone() as any` for deep cloning the settings object. `JSON.parse(JSON.stringify())` is slower due to string serialization/deserialization and cannot handle complex types. `structuredClone` is the native, more efficient way to deep copy objects. Faster deep cloning, saving CPU cycles on the main thread during user input and saves, leading to smoother interactions in the Settings Editor. Co-authored-by: ralksta <16941050+ralksta@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced
JSON.parse(JSON.stringify())with nativestructuredClone() as anyfor deep cloning the settings object.🎯 Why:
JSON.parse(JSON.stringify())is slower due to string serialization/deserialization and cannot handle complex types.structuredCloneis the native, more efficient way to deep copy objects.📊 Impact: Faster deep cloning, saving CPU cycles on the main thread during user input and saves, leading to smoother interactions in the Settings Editor.
🔬 Measurement: Can be measured by profiling the
updateandhandleSavefunctions in the DevTools Performance tab.structuredCloneshould execute in less time than the JSON serialization cycle.PR created automatically by Jules for task 8261323197286948581 started by @ralksta