🎨 Palette: Add ARIA labels and hide text-based icons#302
Conversation
Co-authored-by: ralksta <16941050+ralksta@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
aria-labelandaria-hidden="true"to text-based close ('×') buttons inPageBuilder.tsx,AssetPicker.tsx, andAlbumPicker.tsx.🎯 Why: Text characters used as visual icons (like '×') are often announced poorly by screen readers (e.g. "times" or "multiply"). By wrapping the visual character in an
aria-hiddenspan and providing an explicitaria-labelon the parent<button>, the intended action ("Clear search" or "Close modal") is communicated accurately.📸 Before/After: Visuals remain unchanged. Screen reader output changes from reading confusing math symbols to explicit functional actions.
♿ Accessibility: Improved screen reader announcements for text-based icon buttons, providing clear actionable context instead of raw symbol names.
PR created automatically by Jules for task 15682275450310377440 started by @ralksta