use XDG_CONFIG_HOME in CONF_ROOT definition#11
Open
laur89 wants to merge 2 commits intoram-on:masterfrom
Open
Conversation
laur89
commented
Sep 16, 2025
laur89
commented
- users might have configured their XDG_CONFIG_HOME to a non-standard value, we should respect it
- move imgur api url & api ver to constants
- standardize boolean opts to 'true' string, do not mix with other types
- users might have configured their XDG_CONFIG_HOME to a non-standard value, we should respect it - move imgur api url & api ver to constants
Author
|
Nice to see this project still going strong! Have been using it regularly as a screenshotting dependency for better part of the last decade. |
- it's --fail in its long form - this causes curl to exit w/ error for all HTTP response codes at 400 or greater
Owner
|
Thank you for your pull request. Looks good, though I need to test it. Can you change from single inverted commas to double inverted commas for the sake of consistency please? |
Author
|
You mean on all the values? It's not really a consistency thing. Double quotes signify that there's some value that's expected to be expanded, e.g. variables. Single quotes imply the string is as-is. |
Author
|
Bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.