Skip to content

Conversation

@Moh23John
Copy link

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this directory to Bubbles(Original) breaks the links on the main README.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing it.

@Moh23John Moh23John marked this pull request as draft June 12, 2025 05:18
@SandTechStuff
Copy link
Collaborator

SandTechStuff commented Jun 12, 2025

Maybe it would be better to have the alternate styles in the main Bubbles README, as to be consistent with themes like Lucent (Accented Bar & Light Bar variants)? Probably best to get Micheal's opinion on it.

@Moh23John
Copy link
Author

I'll see the theme you mentioned, and I'll match it with that for now?

@SandTechStuff
Copy link
Collaborator

SandTechStuff commented Jun 12, 2025

I'll see the theme you mentioned, and I'll match it with that for now?

That's just how I think it would be better suited, but Micheal might find a better solution. You don't have to make any changes for now, I would wait for him to respond.

@Moh23John
Copy link
Author

Got it. Should I keep this as a draft? Haven't done this stuff before so sorry If I sound inexperienced,

@SandTechStuff
Copy link
Collaborator

SandTechStuff commented Jun 12, 2025

Should I keep this as a draft?

Up to you. As long as it's clear changes are still being made it shouldn't make much of a difference if its a draft or not.

Haven't done this stuff before so sorry If I sound inexperienced,

No problem at all! You don't sound inexperienced :)

@Moh23John Moh23John marked this pull request as ready for review June 12, 2025 05:28
@m417z
Copy link
Member

m417z commented Jun 15, 2025

Thanks for the contribution @Moh23John. Recently, @bbmaster123 has been working on the Bubbles theme to make it compatible with both the light theme and the dark theme. You can try it by following the manual installation steps here:
https://github.com/ramensoftware/windows-11-taskbar-styling-guide/blob/main/Themes/Bubbles/README.md

Given these recent updates, I'm not sure that your theme variant is still necessary or has any significant changes. What do you think?

@Moh23John
Copy link
Author

Moh23John commented Jun 15, 2025

Thanks for the contribution @Moh23John. Recently, @bbmaster123 has been working on the Bubbles theme to make it compatible with both the light theme and the dark theme. You can try it by following the manual installation steps here:
https://github.com/ramensoftware/windows-11-taskbar-styling-guide/blob/main/Themes/Bubbles/README.md

Given these recent updates, I'm not sure that your theme variant is still necessary or has any significant changes. What do you think?

I'll be checking it out in a bit, will get back to you soon.

@Moh23John
Copy link
Author

Moh23John commented Jun 16, 2025

Thanks for the contribution @Moh23John. Recently, @bbmaster123 has been working on the Bubbles theme to make it compatible with both the light theme and the dark theme. You can try it by following the manual installation steps here: https://github.com/ramensoftware/windows-11-taskbar-styling-guide/blob/main/Themes/Bubbles/README.md

Given these recent updates, I'm not sure that your theme variant is still necessary or has any significant changes. What do you think?

Hey, super sorry for the delay. With no disrespect, my version is quite different from the one that bbmaster has been working on. The original intent wasn't to exactly to build on top of the original theme, but kind of to reinvent the wheel. I looked at the theme, and I said "I could take inspiration from the theme and somewhat restructure it to make it look according to my preferences", which happened to be more monochromatic, minimal, and slightly "greyish", though these themes are similar, they still have some differences. While the original theme does not force the monochromatic and minimal aspect, my one does. I believe they are quite different when they are looked at. I could perhaps readjust the naming system as I can see why this can be easily misunderstood. This was meant to be used with dark mode. I understand the value of your time, and I would be in no way offended if you chose to deny me, but I made this short video just to show the differences between these two themes. In the end, it is up to you wether you want to add this or not.

P.mp4

@bbmaster123
Copy link
Collaborator

@Moh23John
hey, sorry but could you confirm which one is the latest that I should be looking at? I see a readme.md, a .json, and a .jsonc, and I'm thinking the .json is the one I want since it has all the description comments, but I just want to be sure

based on the above video, it appears mainly to be color differences, but I'll look a little deeper in case I'm missing anything important

@Moh23John
Copy link
Author

Moh23John commented Jun 16, 2025

@Moh23John
hey, sorry but could you confirm which one is the latest that I should be looking at? I see a readme.md, a .json, and a .jsonc, and I'm thinking the .json is the one I want since it has all the description comments, but I just want to be sure

based on the above video, it appears mainly to be color differences, but I'll look a little deeper in case I'm missing anything important

Hey, you should be looking at the .JSON. and yeah, it's just the colors and "animation"
color changes. But I believe I did make some alignment changes. Also, the JSONC is the one with the comments. I also did a little bit of a cleanup on the code from my previous commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants