-
Notifications
You must be signed in to change notification settings - Fork 108
Added Bubbles(White) #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added Bubbles(White) #275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming this directory to Bubbles(Original) breaks the links on the main README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing it.
|
Maybe it would be better to have the alternate styles in the main Bubbles README, as to be consistent with themes like Lucent (Accented Bar & Light Bar variants)? Probably best to get Micheal's opinion on it. |
|
I'll see the theme you mentioned, and I'll match it with that for now? |
That's just how I think it would be better suited, but Micheal might find a better solution. You don't have to make any changes for now, I would wait for him to respond. |
|
Got it. Should I keep this as a draft? Haven't done this stuff before so sorry If I sound inexperienced, |
Up to you. As long as it's clear changes are still being made it shouldn't make much of a difference if its a draft or not.
No problem at all! You don't sound inexperienced :) |
|
Thanks for the contribution @Moh23John. Recently, @bbmaster123 has been working on the Bubbles theme to make it compatible with both the light theme and the dark theme. You can try it by following the manual installation steps here: Given these recent updates, I'm not sure that your theme variant is still necessary or has any significant changes. What do you think? |
I'll be checking it out in a bit, will get back to you soon. |
Hey, super sorry for the delay. With no disrespect, my version is quite different from the one that bbmaster has been working on. The original intent wasn't to exactly to build on top of the original theme, but kind of to reinvent the wheel. I looked at the theme, and I said "I could take inspiration from the theme and somewhat restructure it to make it look according to my preferences", which happened to be more monochromatic, minimal, and slightly "greyish", though these themes are similar, they still have some differences. While the original theme does not force the monochromatic and minimal aspect, my one does. I believe they are quite different when they are looked at. I could perhaps readjust the naming system as I can see why this can be easily misunderstood. This was meant to be used with dark mode. I understand the value of your time, and I would be in no way offended if you chose to deny me, but I made this short video just to show the differences between these two themes. In the end, it is up to you wether you want to add this or not. P.mp4 |
|
@Moh23John based on the above video, it appears mainly to be color differences, but I'll look a little deeper in case I'm missing anything important |
Hey, you should be looking at the .JSON. and yeah, it's just the colors and "animation" |
No description provided.