-
Notifications
You must be signed in to change notification settings - Fork 109
Add Luminosity Theme #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Luminosity Theme #397
Conversation
SandTechStuff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I just have a few tweaks for you to look through.
On the docked variant, the MultiWindowElement appears separated from the main taskbar button. This element is notoriously annoying to work with, so an alternative implementation (eg. using a border on the main taskbar buttons) may be needed for it to look proper. Maybe you can figure it out though, through setting height or rendertransforms.
Themes/Luminosity/README.md
Outdated
|
|
||
| ## Known Issues | ||
|
|
||
| - There's [a known limitation](https://github.com/ramensoftware/windhawk-mods/issues/742) with ```AcrylicBrush``` which only works if there's a single taskbar. Taskbar in other monitors may appear transparent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - There's [a known limitation](https://github.com/ramensoftware/windhawk-mods/issues/742) with ```AcrylicBrush``` which only works if there's a single taskbar. Taskbar in other monitors may appear transparent. |
IMO this doesn't need to be here, since its stated in the main README
Themes/Luminosity/README.md
Outdated
| "controlStyles[17].styles[1]": "CornerRadius=$bcr", | ||
| "controlStyles[17].styles[2]": "Margin=0,2,0,2", | ||
|
|
||
| "controlStyles[18].target": "Windows.UI.Xaml.Controls.Panel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come there is a target and no styles? This appears in other places too.
Themes/Luminosity/README.md
Outdated
| "controlStyles[26].target": "Windows.UI.Xaml.Controls.Grid#HoverFlyoutGrid > Windows.UI.Xaml.Controls.Border#HoverFlyoutBackground", | ||
| "controlStyles[26].styles[0]": "Background:=$mbg", | ||
| "controlStyles[26].styles[1]": "CornerRadius=$mcr", | ||
| "controlStyles[26].styles[2]": "Margin=0,0,0,0 future idea", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "controlStyles[26].styles[2]": "Margin=0,0,0,0 future idea", | |
| "controlStyles[26].styles[2]": "//Margin=0,0,0,0 future idea", |
Comment this out or remove since it's not a valid style.
Themes/Luminosity/README.md
Outdated
|
|
||
|
|
||
| "controlStyles[30].target": "Windows.UI.Xaml.Controls.Border#BackgroundDimmingLayer", | ||
| "controlStyles[30].styles[0]": "Background=<WindhawkBlur BlurAmount=\"30\" TintColor=\"#00000000\" />", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "controlStyles[30].styles[0]": "Background=<WindhawkBlur BlurAmount=\"30\" TintColor=\"#00000000\" />", | |
| "controlStyles[30].styles[0]": "Background:=<WindhawkBlur BlurAmount=\"30\" TintColor=\"#00000000\" />", | |
XAML syntax needs a := instead of =
Themes/Luminosity/README.md
Outdated
| "controlStyles[25].target": "Windows.UI.Xaml.Controls.MenuFlyoutPresenter > Windows.UI.Xaml.Controls.Border", | ||
| "controlStyles[25].styles[0]": "CornerRadius=WHYYYY DOESNT IT GET ROUNDED ITS THE WRONG TARGEEEEEEET", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "controlStyles[25].target": "Windows.UI.Xaml.Controls.MenuFlyoutPresenter > Windows.UI.Xaml.Controls.Border", | |
| "controlStyles[25].styles[0]": "CornerRadius=WHYYYY DOESNT IT GET ROUNDED ITS THE WRONG TARGEEEEEEET", |
Comment this out or remove since it's not a valid style.
Themes/Luminosity/README.md
Outdated
| "controlStyles[26].target": "Windows.UI.Xaml.Controls.Grid#HoverFlyoutGrid > Windows.UI.Xaml.Controls.Border#HoverFlyoutBackground", | ||
| "controlStyles[26].styles[0]": "Background:=$mbg", | ||
| "controlStyles[26].styles[1]": "CornerRadius=$mcr", | ||
| "controlStyles[26].styles[2]": "Margin=0,0,0,0 future idea", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "controlStyles[26].styles[2]": "Margin=0,0,0,0 future idea", | |
| "controlStyles[26].styles[2]": "//Margin=0,0,0,0 future idea", |
Comment this out or remove since it's not a valid style.
Themes/Luminosity/README.md
Outdated
|
|
||
|
|
||
| "controlStyles[30].target": "Windows.UI.Xaml.Controls.Border#BackgroundDimmingLayer", | ||
| "controlStyles[30].styles[0]": "Background=<WindhawkBlur BlurAmount=\"30\" TintColor=\"#00000000\" />", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "controlStyles[30].styles[0]": "Background=<WindhawkBlur BlurAmount=\"30\" TintColor=\"#00000000\" />", | |
| "controlStyles[30].styles[0]": "Background:=<WindhawkBlur BlurAmount=\"30\" TintColor=\"#00000000\" />", |
XAML syntax needs a := instead of =
Themes/Luminosity/README.md
Outdated
| "controlStyles[25].target": "Windows.UI.Xaml.Controls.MenuFlyoutPresenter > Windows.UI.Xaml.Controls.Border", | ||
| "controlStyles[25].styles[0]": "CornerRadius=WHYYYY DOESNT IT GET ROUNDED ITS THE WRONG TARGEEEEEEET", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "controlStyles[25].target": "Windows.UI.Xaml.Controls.MenuFlyoutPresenter > Windows.UI.Xaml.Controls.Border", | |
| "controlStyles[25].styles[0]": "CornerRadius=WHYYYY DOESNT IT GET ROUNDED ITS THE WRONG TARGEEEEEEET", |
Comment this out or remove since it's not a valid style.
Themes/Luminosity/README.md
Outdated
| "controlStyles[25].target": "Windows.UI.Xaml.Controls.MenuFlyoutPresenter > Windows.UI.Xaml.Controls.Border", | ||
| "controlStyles[25].styles[0]": "CornerRadius=WHYYYY DOESNT IT GET ROUNDED ITS THE WRONG TARGEEEEEEET", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "controlStyles[25].target": "Windows.UI.Xaml.Controls.MenuFlyoutPresenter > Windows.UI.Xaml.Controls.Border", | |
| "controlStyles[25].styles[0]": "CornerRadius=WHYYYY DOESNT IT GET ROUNDED ITS THE WRONG TARGEEEEEEET", |
Comment this out or remove since it's not a valid style. I feel your pain ;)
Also LMK if you want help to try and fix some of these. |
|
I'll make a cleaner JSON with the changes you suggested. Answering some questions, the unstyled targets were there for me to come back to later, but I'll remove them. I also didn't know about the comments feature, and was just being goofy lol @SandTechStuff
I think these are the most important. Thanks! |
|
I misclicked the re-request review button, I'm sorry. |
May have errors, I'll review it again when I can. - MultiWindowElement fix-ish It's not looking very good, but I also I didn't had the same issue, not sure if it's because of the Windows version. I don't know how the fix is going to behave in other versions. I should be getting 25h2 soon; I had the option to update last week, but it was failing to install. - I think all unstyled targets have been removed - Removed Acrylic limitation from Known Issues
|
For the Compact version, I've found a target related to the Widget text, but both lines have the same name ( |
No problem.
Alright, I'll look into these when I have time. |
|
Thank you very much! I may take some time to apply the updates and work on the project, my house got damages due to bad weather.
Yes, that's what I meant, sorry. |
- Widget icon now fits Compact mode - Window preview border now matches the theme - Rounded close buttons added to window preview and virtual desktops
|
I think I'll leave the Widget bottom text line as it is. In my opinion, it's still readable when hovering the cursor over the widget button. It seems like the Win + X drop shadow hasn't been changed on other styles as well. It would be nice if it could match the corner radius of the menu, so I'm searching from time to time what the target name might be, but maybe I'll leave it as is too. After I decide what to do with the Win + X, I'll redo the screenshots and presentation. |
|
I've found the Win + X target responsible for its drop shadow. :3 |
I've forgotten to add the changelog on the previous update. "A lot" have changed.
- Code remade from scratch, better organized
- Removed drop shadows from most or all things
- Rounded Window Preview Flyout buttons
- Consistent border for Window Preview Flyout
- May look strange when there are multiple windows, I don't know what to do with it at the moment
- Rounded Right-Click menu items when hovering over them
- Removed Search pill styles from Dock and Classic versions
- To reduce issues when using the Search box
- Small changes to improve consistency, may not be worth mentioning
- Removed redundancies and generic targets - Added styles to ```SystemTray.Stack#MainStack``` (```SystemTray.IconView#SystemTrayIcon```) - Consistent spacing between tray elements (I hope) - Classic version tweaks
SandTechStuff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
| "controlStyles[15].target": "Taskbar.TaskItemThumbnailView > Grid@CommonStates > Border#BackgroundBorder", | ||
| "controlStyles[15].styles[0]": "Background=$t", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add some thumbnail preview background color changes for the different hover states, so that it is more clear where your mouse is hovering. Right now it uses one background color no matter if you are not hovering, hovering, or pressing the thumbnail preview.
Or you could remove this style, as I think the stock background color changes look fine. The modified acrylic is applied on target 14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the hover background because I felt it was compromising the acrylic look; the hovering layer made the material look more "flat."
You can still tell which window you’re hovering by the close button, so I removed it on purpose.
If that's okay I would like to keep it this way, but If you really think it feels incomplete visually, I thought of this:

"controlStyles[15].target": "Taskbar.TaskItemThumbnailView > Grid@CommonStates > Border#BackgroundBorder",
"controlStyles[15].styles[0]": "Background:=$t",
"controlStyles[15].styles[1]": "BorderThickness=$bt",
"controlStyles[15].styles[2]": "CornerRadius=$mcr",
"controlStyles[15].styles[3]": "BorderBrush@Normal=$t",
"controlStyles[15].styles[4]": "BorderBrush@PointerOver=#23FFFFFF",

Luminosity - Theme Pack
Luminosity is based on native Acrylic, using the maximum TintLuminosityOpacity value as its backdrop.
It’s meant to be used with Mica or MicaAlt backdrops, with or without Translucent Windows.
I’d like to know if this is a worthwhile contribution. I’ve tried to fix several visual issues, but I’m not sure if I missed any beyond the known ones. If there are complex issues, I might need help fixing them since I’m still new to programming. XP
Overview
Windowglass provided AMAZING help on this theme pack. Thank you, Nathaniel!
I’ve made three Taskbar variants:
Compact
This one is based on personal preference, I like having a smaller Taskbar while working.
I’ve reduced its height “as much as possible.” (I guess)
Since the icons are smaller, it’s meant to be used with Taskbar Labels for Windows 11, using the Centered Running Indicator style. Otherwise, the indicator will clip into the icons.
Also since the Taskbar is smaller, I recommend using Taskbar Clock Customization.
Dock
Docks are also pretty cool!
This version should have the same height as the normal Taskbar.
Unfortunately, the corner radius slightly limits the icon hitbox on the top and bottom, which makes it impossible to minimize windows by clicking in those areas.
Classic
The Dock version can be “easily” reverted to a standard Taskbar layout by deleting the targets after stylesConstants, keeping the theme pack’s visual effects.
It’s designed to cause minimal disruption for users who prefer the classic Taskbar placement.
General Information
The theme changes the following elements:
Known Issues
AcrylicBrush.I didn’t know how to fix these. I couldn’t find the correct target names, or I’m not sure if they can even be changed.
Notes and Questions
I really love the Windhawk project, thank you!

