Open
Conversation
Contributor
steven11sjf
commented
Mar 23, 2026
steven11sjf
commented
- Waiting on corresponding odr-exlaunch patch
- Adds a patcher option configuration.cosmetic_options.split_saves
- bool, default false
- If this is true, generates a file "romfs:/RDVHASH" with a cstring "RDV_(Seed Identifier)_(Layout UUID)"
- Exlaunch uses this file to store saves 1/2/3 in separate slots than the "profile0/1/2" folders
- Added tests to ensure valid export for split_saves being missing, false or true
- Waiting on corresponding odr-exlaunch patch - Adds a patcher option configuration.cosmetic_options.split_saves - bool, default false - If this is true, generates a file "romfs:/RDVHASH" with a cstring "RDV_(Seed Identifier)_(Layout UUID)" - Exlaunch uses this file to store saves 1/2/3 in separate slots than the "profile0/1/2" folders - Added tests to ensure valid export for split_saves being missing, false or true
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
+ Coverage 92.12% 92.15% +0.02%
==========================================
Files 38 38
Lines 2160 2166 +6
==========================================
+ Hits 1990 1996 +6
Misses 170 170 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
duncathan
requested changes
Apr 18, 2026
| return | ||
|
|
||
| save_key = f"RDV_{configuration['configuration_identifier']}_{configuration['layout_uuid']}" | ||
| editor.add_new_asset("RDVHASH", bytes(save_key, encoding="ascii"), in_pkgs=[]) |
Contributor
There was a problem hiding this comment.
can you use save_key.encode("ascii") instead?
…-dread-rando into separated-saves
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.