Add Area.get_dock - #323
Open
henriquegemignani wants to merge 1 commit into
Open
Conversation
duncathan
reviewed
Jun 14, 2026
Comment on lines
+923
to
+931
| def get_dock(self, dock_name: str) -> ScriptInstance: | ||
| """Gets the script object of type Dock with the given name.""" | ||
| from retro_data_structures.properties.shared_objects import Dock | ||
|
|
||
| for instance in self.all_instances: | ||
| if instance.name == dock_name and instance.script_type in Dock.__args__: | ||
| return instance | ||
|
|
||
| raise KeyError(f"No object of type Dock and name {dock_name} found.") |
Contributor
There was a problem hiding this comment.
should we consider adding a type parameter to get_instance, rather than having a dedicated method for docks in particular?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
- Coverage 74.95% 74.93% -0.02%
==========================================
Files 95 95
Lines 6811 6818 +7
Branches 890 893 +3
==========================================
+ Hits 5105 5109 +4
- Misses 1537 1539 +2
- Partials 169 170 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.