Converted to Chef provisioning by 0xbadshah · Pull Request #174 · rapid7/metasploitable3

0xbadshah · 2017-08-04T23:27:12Z

This PR converts the provisioning from shell to chef-solo in packer. As there is an issue with chef-solo provisioning in packer, a Vagrantfile is included under /versions/chef folder which does the same but using vagrant.

To test the vagrant build, the files (Vagrantfile and windows_2008_r2.json) should be manually moved to the metasploitable3 folder and replace the default ones.

Verification:

Move and replace the Vagrantfile and windows_2008_r2.json file in the main folder with those present in the /versions/chef folder
Build the base box using packer build --only=virtualbox-iso windows_2008_r2.json. Verify the system comes up successfully.
Add the base box using the command vagrant box add mtest windows_2008_r2_virtualbox.box
Try starting the system using vagrant up

commit 9d6666fbb9f066179e17030808bd02e3ad27a2c0 Author: Chan9390 <bnchandrapal@gmail.com> Date: Fri Jul 28 18:20:46 2017 +0530 Removed cmd /c from commands commit ef6abe66f4a79e150c9d85a0a38896b061bc5def Author: Chan9390 <bnchandrapal@gmail.com> Date: Fri Jul 28 07:14:52 2017 +0530 Added certificates

- Updated to powershell resource - Added vagrant ssh

- Converted to chef - Enabled RDP

- Updated registry entries to chef resources - Updated registry entries - Updated user groups - Added users

- Converted to batch resource - Setup IIS

- Converted to chef - Added Apache Struts

- Converted to chef - Added scripts to start glassfish - Added GlassFish

- Converted to chef - Added jenkins

- Converted to chef - Added code to start WAMP - Added WAMP

Squashed commit of the following: - Moved ruby - Moved java - Moved tomcat - Moved jdk8 - Moved vcredist - Moved 7zip - Moved 7zip

Squashed commit of the following: - Added everything to default - put everything to default - Linked jenkins to java and jdk8 - Linked backdoors to iis and wamp - Linked flags to iis and wamp - Linked ftp to iis - Linked rails to devkit - Linked devkit to 7zip and ruby - Linked struts to tomcat and java - Linked axis2 to tomcat - Linked elasticsearch to 7zip and jdk8 - Linked mysql to wordpress and wamp - Linked webdav to wamp - Linked wordpress to 7zip and vcredist - Linked wamp to vcredist - Linked jmx to openjdk6 - Linked openjdk to 7zip - Linked tomcat to jdk8

- Updated wamp - Updated openjdk6 - Updated glassfish - Updated devkit - Updated axis2 - Updated vagrant_ssh - Updated elasticsearch

Sliim

Some execute / batch resources make the metasploitable cookbook not idempotent.

Sliim · 2017-09-13T00:14:53Z

chef/cookbooks/metasploitable/recipes/apache_struts.rb

+
+file 'C:\Program Files\Apache Software Foundation\tomcat\apache-tomcat-8.0.33\conf\tomcat-users.xml' do
+  action :delete
+end


This is not idempotent, the cookbook_file resource will override this file you don't need to delete it.

Sliim · 2017-09-13T00:17:19Z

chef/cookbooks/metasploitable/recipes/cleaner.rb

+
+directory 'C:\vagrant' do
+  recursive true
+  action :delete


Are you trying to remove a shared folder?

Yes. If the folder C:\vagrant exists in the packer build, some issues occur when starting the box using vagrant.

Hmm ok, I think this can be dangerous if user mounted a local directory to the guest at C:\vagrant.. no?

Sliim · 2017-09-13T00:18:36Z

chef/cookbooks/metasploitable/recipes/configure_firewall.rb

+# Copyright:: 2017, The Authors, All Rights Reserved.
+
+execute 'Closed port 445 for SMB' do
+  command 'netsh advfirewall firewall add rule name="Closed port 445 for SMB" dir=in action=block protocol=TCP localport=445'


What happen if the rule already exists?

Sliim · 2017-09-13T00:23:52Z

chef/cookbooks/metasploitable/recipes/elasticsearch.rb

+end
+
+execute 'Starting service' do
+  command '"C:\Program Files\elasticsearch-1.1.1\bin\service.bat" start'


Why not using actions [:enable, :start] for windows_service[elasticsearch-service-x64] resource? instead of this execute?

Sliim · 2017-09-13T00:24:10Z

chef/cookbooks/metasploitable/recipes/elasticsearch.rb

+  action :run
+end
+
+powershell_script 'Test response' do


Sliim · 2017-09-13T00:27:21Z

chef/cookbooks/metasploitable/recipes/flags.rb

+
+cookbook_file 'C:\Windows\three_of_spades.png' do
+  source 'flags/three_of_spades.png'
+  action :create


Should you use the mode, owner, group etc.. attributes instead of the batch resource below?

Sliim · 2017-09-13T00:28:39Z

chef/cookbooks/metasploitable/recipes/flags.rb

+  action :create
+end
+
+file 'C:\inetpub\wwwroot\iisstart.htm' do


Why this here? In the flags recipe?

Sliim · 2017-09-13T00:30:11Z

chef/cookbooks/metasploitable/recipes/glassfish.rb

+  action [:enable, :start]
+end
+
+ruby_block 'Sleep for 15 secs' do


Glassfish installation runs at the background and it needs some time to get installed. So I had introduced a time delay using ruby block resource.

Sliim · 2017-09-13T00:36:33Z

chef/cookbooks/metasploitable/recipes/webdav.rb

+  action :create
+end
+
+windows_service 'wampapache' do


You shoukd use resource notifications instead of a service stop/start
https://docs.chef.io/resource_common.html#notifications

0xbadshah added 30 commits July 28, 2017 07:08

Initial chef commit

31c1140

Disable auto logon

d10e6a6

Disabled firewall

25f699d

Changed name of batch resource

48c17d8

Install Boxstarter

5d350cf

Added 7zip

58ffb5b

Apply password settings

00c6ea3

Setup FTP

f116738

Install Java

109fac0

Added Tomcat

44dc582

Added vcredist2008

e0872d2

Added Ruby

9ec163c

Committed the following:

c07e1b6

- Updated to powershell resource - Added vagrant ssh

Disabled Auto-logon

d1dfa35

Squashed commit of the following:

73589c0

- Converted to chef - Enabled RDP

Disabled firewall

613733a

Install BoxStarter

a35dfd2

Added 7zip

cadd5da

Configure password settings

b7e0295

Squashed commit of the following:

68c47da

- Updated registry entries to chef resources - Updated registry entries - Updated user groups - Added users

Squashed commit of the following:

728c50e

- Converted to batch resource - Setup IIS

Setup FTP

601c682

Added Java

818315f

Added Tomcat

ffd101b

Squashed commit of the following:

96d33bd

- Converted to chef - Added Apache Struts

Squashed commit of the following:

bd7ee0e

- Converted to chef - Added scripts to start glassfish - Added GlassFish

Squashed commit of the following:

6a6ed95

- Converted to chef - Added jenkins

Added vcredist2008

47c2416

Squashed commit of the following:

589d740

- Converted to chef - Added code to start WAMP - Added WAMP

0xbadshah added 29 commits August 12, 2017 16:13

Changed batch resource to execute in ruby

9f10e0b

Added JDK 8

9006d4e

Corrected mistake in elasticsearch recipe

b4e2607

Corrected mistake in packer file

c11a5f1

Removed file provisioners

62ced68

Updated flags

16d7352

Updated files

e1a2006

Converted batch to execute resource

0cf5abe

Updated rails

3ea874a

Added 30s pause to get powershell completely installed

bb1c6fd

Updated metadata.rb

749d9c7

Added -y tag to vcredist install

448db9c

Moved execute resource to chocolatey_package

ded8b00

Squashed commit of the following: - Moved ruby - Moved java - Moved tomcat - Moved jdk8 - Moved vcredist - Moved 7zip - Moved 7zip

Added IIS and SNMP

5c422bd

Removed BoxStarter from packer provisioner

45689b9

Replaced batch resource to choco in BoxStarter recipe

28e6e76

Added file

bd93c20

Linked b64 file

020ac27

Added vagrantfile to versions folder

a01119d

Removed executable file permission

f9ce6cc

Updated elasticsearch.rb

e9e4e9b

Added rails app

a9b9f19

Updated elasticsearch.rb

12c5eb2

Added check condition in elasticsearch.rb

4b71961

Converted sleep to ruby_block

eba06a6

Squashed commit of the following:

9751b97

- Updated wamp - Updated openjdk6 - Updated glassfish - Updated devkit - Updated axis2 - Updated vagrant_ssh - Updated elasticsearch

Minor changes

1f549fd

Added firewall rules

bf97e32

Sliim reviewed Sep 13, 2017

View reviewed changes

Conversation

0xbadshah commented Aug 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sliim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

0xbadshah commented Aug 4, 2017 •

edited

Loading