add a status function to proftpd service file#604
Draft
deargle wants to merge 2 commits intorapid7:masterfrom
Draft
add a status function to proftpd service file#604deargle wants to merge 2 commits intorapid7:masterfrom
deargle wants to merge 2 commits intorapid7:masterfrom
Conversation
Without it, chef wouldn't actually start the service, concluding for some reason I haven't quite pinned down yet that the service was already running. An alternative would be to bypass chef's checks and do a chef `execute do command service start`, but I think this is cleaner? The matching pattern for pgrep is `^proftpd` is because the server shows up as `proftpd: (accepting connections)` The matching against the full line in combination with `^` is needed because otherwise pgrep also matches against `/etc/init.d/proftpd`, which maybe is why chef was failing in the first place? this might be affecting other metasploitable services...
Contributor
Author
|
sorry, wait on this. it's still not fixed. Still debugging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without it, chef wouldn't actually start the service, concluding for some reason I haven't quite pinned down yet that the service was already running. Perhaps I didn't notice because the service would come up on reboot due to
enableworking (I think).An alternative would be to bypass chef's checks and do a chef
execute do command service start, but I think this is cleaner?The matching pattern for pgrep is
^proftpdis because the server shows up asproftpd: (accepting connections)The matching against the full line(-f) in combination with^is needed because otherwise pgrep also matches against/etc/init.d/proftpd, which maybe is why chef was failing in the first place?this might be affecting other metasploitable services...