Adding todo #13
Open
Adding todo #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
item or item.id as data to removeTodo
from todoList from localStorage
src/components/todoList/TodoList.jsx
Outdated
|
|
||
| render() { | ||
| const { todoList, removeTodo } = this.props; | ||
| const btnAdd = <button onClick={this.onAddBtn}>+</button>; |
There was a problem hiding this comment.
Такое лучше выносить в методы класса, либо в отдельый компонент
src/components/todoList/TodoList.jsx
Outdated
| const { todoList, removeTodo } = this.props; | ||
| const btnAdd = <button onClick={this.onAddBtn}>+</button>; | ||
|
|
||
| const renderItem = todoList.map(item => |
There was a problem hiding this comment.
аналогично, лучше вынести в отдельный метод
src/reducers/todoReducer.js
Outdated
| } from '../utils.js'; | ||
|
|
||
| const initialState = { | ||
| todoList: getFromLocalStorage(TODOLIST) |
There was a problem hiding this comment.
Если два разных слово, то в коснтантах пишут через _ -> TODO_LIST
src/components/todoList/TodoList.jsx
Outdated
|
|
||
| return ( | ||
| <div> | ||
| <input onChange={this.onInputChange} type='text' /> {btnAdd} |
There was a problem hiding this comment.
в инпут надо value записывать из стейта
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Так?