Implement search #15
Draft
Implement search #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also i hope this fixes it (probably wont, cant even test in `act` either D:
`jiff` doesn't yet have ecosystem support, unfortunately! `chrono` is still pretty good, though :)
reduces string stuff in tests and likely elsewhere in the future :D
see #11 for more info this just makes search a little easier to implement for now :)
tags are no longer name-based :) that's because i want to have a table in the db for them! and that helps with caching and knowing 'what' to look for
we were doing this manually before
it doesn't really make much sense. in the future, i'll come back with better types for a `Between` modifier!
`SimpleExpr` makes queries much easier to construct dynamically! it also prevents mistakes (and spares me from writing a grammar lol)
i forgot to make them a lot lol
why was i splitting that loool
that makes it work for some reason should probably read the internals at some point but whatever, this does fine for now..!
makes the code easier to edit + simplifies test creation :)
making that a field will make searching by album muuuuch easier!
otherwise, they're all using the same database and messing with each other lol
the high second cts make tests really annoying lol
uuids likely shouldn't be stored within media metadata. if a user wants to modify it from another device, it won't recognize the tags! in addition, i think we'll do something like adding metadata fields for different tag sections, which should be easier to parse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, I implement search using the
sea-querycrate and some fun SQL syntax.See: #10