Shifts __cplusplus check to a higher level for bool type define. Fixes raymath floating point comparison issues. Adds missing default define for RAYMATH_USE_SIMD_INTRINSICS#5804
Open
lamweilun wants to merge 4 commits intoraysan5:masterfrom
Conversation
Contributor
Author
|
I have also bolted on some additional fixes for raymath, mostly its with the floating point comparison fixes. Also there's a missing base define for |
Owner
|
@lamweilun Please, could you split those changes into two separate PRs, also, raymath convention is avoiding functions calling other functions, please, review that, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reason for this change is that, C++ compilers, or at least g++ and clang++ from my own testing, defines STDC but not STDC_VERSION. And when compiling with -Wundef, it would trigger an error when its checking for STDC_VERSION.
This change basically says, check if you're a C++ compiler first before even entering any of the bool type definition since C++ has bool as a built-in type.