Close menu on click #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi, can we merge this? |
Owner
|
Hi @isopropylcyanide Nowadays I became very busy with my personal job. I couldn't manage the time to test the behavior you implemented. Have you tested locally? If everything works as expected I can merge. |
rbrahul
previously approved these changes
Oct 8, 2019
Owner
rbrahul
left a comment
rbrahul
left a comment
There was a problem hiding this comment.
Hei your changes seem fine. Thanks for your contribution. I am going to merge it 🙂
Author
Yes, everything works as expected :) Thank you for the merge |
Author
|
@rbrahul Resolved merge conflicts. Can we merge this? |
Author
|
Bump @rbrahul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: