Skip to content

Conversation

@maggie98choy
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@maggie98choy maggie98choy changed the base branch from main to 3.0.rc September 17, 2025 18:44
@maggie98choy maggie98choy requested review from a team and Vinodsathyaseelan September 17, 2025 18:59
),
};
send_response(&service_id, &sender, &service_message);
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about event response ? We are currently handling only result and error use cases. Event notification will not have either of these.

@github-actions
Copy link

Code Coverage

Package Line Rate Health
core.main.src.processor.storage 0%
core.sdk.src.api 46%
core.main.src.utils 30%
core.tdk.src.utils 0%
core.sdk.src.extn.ffi 0%
core.main.src.bootstrap.manifest 0%
core.sdk.src.api.manifest 75%
core.sdk.src.utils 63%
core.main.src.bootstrap.extn 0%
core.main.src.service.apps 25%
core.sdk.src.api.gateway 69%
core.sdk.src.api.distributor 68%
core.sdk.src.api.observability 57%
core.sdk.src.service 19%
device.thunder_ripple_sdk.src.client 67%
core.main.src.broker.thunder 37%
core.sdk.src.service.mock_app_gw.appgw 0%
core.main.src.firebolt 2%
core.main.src.service.ripple_service 7%
core.main.src.broker 70%
core.main.src.state.cap 43%
core.sdk.src.extn.client 82%
core.tdk.src.gateway 100%
device.mock_device.src 55%
core.main.src.broker.test 90%
core.sdk.src.service.mock_app_gw 0%
core.main.src.service.extn 25%
core.sdk.src.extn 77%
core.sdk.src.framework 64%
core.main.src 0%
core.main.src.broker.rules 78%
device.thunder_ripple_sdk.src.processors 17%
core.main.src.processor 0%
core.main.src.bootstrap 0%
core.main.src.firebolt.handlers 12%
core.main.src.state 36%
device.thunder_ripple_sdk.src.bootstrap 0%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.service 35%
core.sdk.src.manifest 0%
device.thunder_ripple_sdk.src 17%
core.sdk.src.processor 4%
core.sdk.src.api.device 77%
device.thunder_ripple_sdk.src.events 4%
core.sdk.src.api.firebolt 85%
Summary 49% (21727 / 43997)

Minimum allowed line rate is 47%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants