RDKEMW-9474: support multiple IRDB vendors

[egalla204]

No description provided.

[Copilot]

Pull Request Overview

This PR adds support for multiple IRDB (IR Database) vendors and the ability to set a preferred vendor. The changes enable the system to query all supported IRDB vendors and configure which vendor to use based on RCU (Remote Control Unit) capabilities.

Key changes include:

• Added two new API functions: ctrlm_irdb_get_supported_vendor_info() to retrieve all installed IRDB vendors and ctrlm_irdb_set_preferred_vendor() to configure the preferred vendor
• Implemented plugin loading support with fallback to stub implementations when the plugin methods are unavailable
• Updated the BLE controller to set the preferred vendor based on RCU support bitmask

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/irdb/ctrlm_irdb_stub.h	Added stub declarations for the two new vendor-related functions
src/irdb/ctrlm_irdb_stub.cpp	Implemented stub functions that log "not implemented" and return false
src/irdb/ctrlm_irdb_plugin.h	Added public API declarations with documentation comments
src/irdb/ctrlm_irdb_interface.h	Added set_vendor() method to the interface class
src/irdb/ctrlm_irdb_interface.cpp	Implemented plugin loading, function pointer setup, and interface methods with vendor info logging
src/ble/ctrlm_ble_controller.cpp	Updated to call set_vendor() before retrieving vendor info and changed log level from INFO to WARN on failure

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The return value from pluginGetSupportedVendors overwrites the ret variable that was set by pluginOpen on line 293. If pluginOpen succeeds but pluginGetSupportedVendors fails, the function will incorrectly return false. Use a separate variable for the supported vendors check, e.g., bool supported_ret = (*g_irdb.pluginGetSupportedVendors)(supported_vendors);

Suggested change

	if ((ret = (*g_irdb.pluginGetSupportedVendors)(supported_vendors)) == true) {
	bool supported_ret = (*g_irdb.pluginGetSupportedVendors)(supported_vendors);
	if (supported_ret == true) {

[Copilot]

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/irdb/ctrlm_irdb_stub.cpp:1

• Parameter passing inconsistency between header and implementation. The stub header declares this function taking ctrlm_irdb_vendor_info_t by value (line 37 in ctrlm_irdb_stub.h), but the implementation uses const ctrlm_irdb_vendor_info_t &info. Update the header to match the implementation and use const reference, which also aligns with the plugin API signature.

/*

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/irdb/ctrlm_irdb_interface.cpp:1

• The set_vendor call passes a vendor_info struct with only the rcu_support_bitmask field populated and an empty name field. The API comment in ctrlm_irdb_plugin.h (line 95) mentions this 'will basically pass through the bitmask coming from the RCU', but it's unclear how the plugin should handle a partially populated struct. Consider documenting whether the name field should be ignored or if this pattern is expected.

/*

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The vendor_info struct is reused for both setting and getting vendor information. After calling set_vendor(vendor_info) with only the rcu_support_bitmask set, the same variable is passed to get_vendor_info(vendor_info), which will overwrite it. This could lead to confusion since the name field is empty when setting but may be populated when getting. Consider using separate variables or adding a comment to clarify this pattern is intentional.

Suggested change

	ctrlm_irdb_vendor_info_t vendor_info{};
	vendor_info.rcu_support_bitmask = vendor_support_bitmask;
	irdb->set_vendor(vendor_info);
	if (irdb->get_vendor_info(vendor_info)) {
	XLOGD_INFO("Controller <%s> IRDBs supported bitmask = <0x%X>, which %s support the loaded IRDB plugin vendor <%s>",
	ieee_address_get().to_string().c_str(), vendor_support_bitmask,
	isSupportedIrdb(vendor_info) ? "DOES" : "does NOT", vendor_info.name.c_str());
	ctrlm_irdb_vendor_info_t vendor_info_set{};
	vendor_info_set.rcu_support_bitmask = vendor_support_bitmask;
	irdb->set_vendor(vendor_info_set);
	ctrlm_irdb_vendor_info_t vendor_info_get{};
	if (irdb->get_vendor_info(vendor_info_get)) {
	XLOGD_INFO("Controller <%s> IRDBs supported bitmask = <0x%X>, which %s support the loaded IRDB plugin vendor <%s>",
	ieee_address_get().to_string().c_str(), vendor_support_bitmask,
	isSupportedIrdb(vendor_info_get) ? "DOES" : "does NOT", vendor_info_get.name.c_str());